scsi: mpt3sas: Demote log level for trace buffer allocation to info

[PATCH] scsi: mpt3sas: Demote log level for trace buffer allocation to info

Posted by Paul Menzel 2 years, 8 months ago

On a system with the controller below

    01:00.0 Serial Attached SCSI controller [0107]: Broadcom / LSI Fusion-MPT 12GSAS/PCIe Secure SAS38xx [1000:00e6]

Linux logs the error below:

    $ dmesg --level=err | grep mpt
    [    7.647675] mpt3sas_cm0: Trace buffer memory 2048 KB allocated

This state does not denote an error condition (and also no warning), so
demote the level from error to info.

Cc: it+linux-scsi@molgen.mpg.de
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 drivers/scsi/mpt3sas/mpt3sas_ctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
index 0d8b1e942ded..efdb8178db32 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
@@ -1884,7 +1884,7 @@ mpt3sas_enable_diag_buffer(struct MPT3SAS_ADAPTER *ioc, u8 bits_to_register)
 			    diag_register.requested_buffer_size>>10);
 		else if (ioc->diag_buffer_status[MPI2_DIAG_BUF_TYPE_TRACE]
 		    & MPT3_DIAG_BUFFER_IS_REGISTERED) {
-			ioc_err(ioc, "Trace buffer memory %d KB allocated\n",
+			ioc_info(ioc, "Trace buffer memory %d KB allocated\n",
 			    diag_register.requested_buffer_size>>10);
 			if (ioc->hba_mpi_version_belonged != MPI2_VERSION)
 				ioc->diag_buffer_status[
-- 
2.39.0

Re: [PATCH] scsi: mpt3sas: Demote log level for trace buffer allocation to info

Posted by Martin K. Petersen 2 years, 7 months ago

On Tue, 03 Jan 2023 16:04:37 +0100, Paul Menzel wrote:

> On a system with the controller below
> 
>     01:00.0 Serial Attached SCSI controller [0107]: Broadcom / LSI Fusion-MPT 12GSAS/PCIe Secure SAS38xx [1000:00e6]
> 
> Linux logs the error below:
> 
>     $ dmesg --level=err | grep mpt
>     [    7.647675] mpt3sas_cm0: Trace buffer memory 2048 KB allocated
> 
> [...]

Applied to 6.3/scsi-queue, thanks!

[1/1] scsi: mpt3sas: Demote log level for trace buffer allocation to info
      https://git.kernel.org/mkp/scsi/c/1eeedfad9a14

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: mpt3sas: Demote log level for trace buffer allocation to info

Posted by Martin K. Petersen 2 years, 8 months ago

Paul,

> Linux logs the error below:
>
>     $ dmesg --level=err | grep mpt
>     [    7.647675] mpt3sas_cm0: Trace buffer memory 2048 KB allocated
>
> This state does not denote an error condition (and also no warning),
> so demote the level from error to info.

Applied to 6.3/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering