[PATCH net] net: phy: Update documentation for get_rate_matching

Sean Anderson posted 1 patch 2 years, 8 months ago
include/linux/phy.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
[PATCH net] net: phy: Update documentation for get_rate_matching
Posted by Sean Anderson 2 years, 8 months ago
Now that phylink no longer calls phy_get_rate_matching with
PHY_INTERFACE_MODE_NA, phys no longer need to support it. Remove the
documentation mandating support.

Fixes: 7642cc28fd37 ("net: phylink: fix PHY validation with rate adaption")
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

 include/linux/phy.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/include/linux/phy.h b/include/linux/phy.h
index 71eeb4e3b1fd..6378c997ded5 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -826,10 +826,7 @@ struct phy_driver {
 	 * whether to advertise lower-speed modes for that interface. It is
 	 * assumed that if a rate matching mode is supported on an interface,
 	 * then that interface's rate can be adapted to all slower link speeds
-	 * supported by the phy. If iface is %PHY_INTERFACE_MODE_NA, and the phy
-	 * supports any kind of rate matching for any interface, then it must
-	 * return that rate matching mode (preferring %RATE_MATCH_PAUSE to
-	 * %RATE_MATCH_CRS). If the interface is not supported, this should
+	 * supported by the phy. If the interface is not supported, this should
 	 * return %RATE_MATCH_NONE.
 	 */
 	int (*get_rate_matching)(struct phy_device *phydev,
-- 
2.35.1.1320.gc452695387.dirty
Re: [PATCH net] net: phy: Update documentation for get_rate_matching
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 8 months ago
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Thu, 29 Dec 2022 15:21:20 -0500 you wrote:
> Now that phylink no longer calls phy_get_rate_matching with
> PHY_INTERFACE_MODE_NA, phys no longer need to support it. Remove the
> documentation mandating support.
> 
> Fixes: 7642cc28fd37 ("net: phylink: fix PHY validation with rate adaption")
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> 
> [...]

Here is the summary with links:
  - [net] net: phy: Update documentation for get_rate_matching
    https://git.kernel.org/netdev/net/c/6d4cfcf97986

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html