[PATCH] kbuild: sort single-targets alphabetically again

Masahiro Yamada posted 1 patch 2 years, 8 months ago
There is a newer version of this series
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] kbuild: sort single-targets alphabetically again
Posted by Masahiro Yamada 2 years, 8 months ago
This was previously alphabetically sorted. Sort it again.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index c0d7c75d8f14..563ec1d8dd2f 100644
--- a/Makefile
+++ b/Makefile
@@ -289,7 +289,7 @@ no-compiler-targets := $(no-dot-config-targets) install dtbs_install \
 			headers_install modules_install kernelrelease image_name
 no-sync-config-targets := $(no-dot-config-targets) %install kernelrelease \
 			  image_name
-single-targets := %.a %.i %.rsi %.ko %.lds %.ll %.lst %.mod %.o %.s %.symtypes %/
+single-targets := %.a %.i %.ko %.lds %.ll %.lst %.mod %.rsi %.o %.s %.symtypes %/
 
 config-build	:=
 mixed-build	:=
-- 
2.34.1
Re: [PATCH] kbuild: sort single-targets alphabetically again
Posted by Miguel Ojeda 2 years, 8 months ago
On Thu, Dec 29, 2022 at 9:08 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> -single-targets := %.a %.i %.rsi %.ko %.lds %.ll %.lst %.mod %.o %.s %.symtypes %/
> +single-targets := %.a %.i %.ko %.lds %.ll %.lst %.mod %.rsi %.o %.s %.symtypes %/

My bad, sorry. I added the `.rsi` near the `.i` due to the similarity
in purpose.

But it should go after `.o`, right? With that change:

Reviewed-by: Miguel Ojeda <ojeda@kernel.org>

Cheers,
Miguel
Re: [PATCH] kbuild: sort single-targets alphabetically again
Posted by Masahiro Yamada 2 years, 8 months ago
On Thu, Dec 29, 2022 at 7:08 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Thu, Dec 29, 2022 at 9:08 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > -single-targets := %.a %.i %.rsi %.ko %.lds %.ll %.lst %.mod %.o %.s %.symtypes %/
> > +single-targets := %.a %.i %.ko %.lds %.ll %.lst %.mod %.rsi %.o %.s %.symtypes %/
>
> My bad, sorry. I added the `.rsi` near the `.i` due to the similarity
> in purpose.
>
> But it should go after `.o`, right? With that change:


My bad - I will send v2.



>
> Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
>
> Cheers,
> Miguel



-- 
Best Regards
Masahiro Yamada