[PATCH v3] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp

Youghandhar Chintala posted 1 patch 2 years, 8 months ago
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
1 file changed, 1 insertion(+)
[PATCH v3] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp
Posted by Youghandhar Chintala 2 years, 8 months ago
Currently, depth-charge Chrome OS bootloader code used in the SC7280
SoC accesses the WiFi node using node names (wifi@<addr>). Since
depth-charge Chrome OS bootloader is a common code that is used in
SoCs having different WiFi chipsets, it is better if the depth-charge
Chrome OS bootloader code accesses the WiFi node using a WiFi alias.
The advantage of this method is that the depth-charge Chrome OS
bootloader code need not be changed for every new WiFi chip.
Therefore, add wifi alias entry for SC7280-idp device tree.

Signed-off-by: Youghandhar Chintala <quic_youghand@quicinc.com>
---
V3:
 - Replaced bootloader with Depth-charge Chrome OS bootloader
   in the commit message
---
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index cd432a2856a7..c4f88d7b3758 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -18,6 +18,7 @@ / {
 	aliases {
 		bluetooth0 = &bluetooth;
 		serial1 = &uart7;
+		wifi0 = &wifi;
 	};
 
 	max98360a: audio-codec-0 {
-- 
2.38.0
Re: [PATCH v3] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp
Posted by Bjorn Andersson 2 years, 8 months ago
On Wed, 28 Dec 2022 15:11:03 +0530, Youghandhar Chintala wrote:
> Currently, depth-charge Chrome OS bootloader code used in the SC7280
> SoC accesses the WiFi node using node names (wifi@<addr>). Since
> depth-charge Chrome OS bootloader is a common code that is used in
> SoCs having different WiFi chipsets, it is better if the depth-charge
> Chrome OS bootloader code accesses the WiFi node using a WiFi alias.
> The advantage of this method is that the depth-charge Chrome OS
> bootloader code need not be changed for every new WiFi chip.
> Therefore, add wifi alias entry for SC7280-idp device tree.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp
      commit: dc58c4d160e72cb28445074c54cc5069bda086a5

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH v3] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp
Posted by Krzysztof Kozlowski 2 years, 8 months ago
On 28/12/2022 10:41, Youghandhar Chintala wrote:
> Currently, depth-charge Chrome OS bootloader code used in the SC7280
> SoC accesses the WiFi node using node names (wifi@<addr>). Since
> depth-charge Chrome OS bootloader is a common code that is used in
> SoCs having different WiFi chipsets, it is better if the depth-charge
> Chrome OS bootloader code accesses the WiFi node using a WiFi alias.
> The advantage of this method is that the depth-charge Chrome OS
> bootloader code need not be changed for every new WiFi chip.
> Therefore, add wifi alias entry for SC7280-idp device tree.
> 
> Signed-off-by: Youghandhar Chintala <quic_youghand@quicinc.com>
> ---
> V3:
>  - Replaced bootloader with Depth-charge Chrome OS bootloader
>    in the commit message
> ---
>  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof