.../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
Move the new 'regulator-vph-pwr' node before the wlan regulator node to
restore the root-node sort order (alphabetically by node name).
While at it, add a couple of newlines to separate the properties for
consistency with the other regulator nodes.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
.../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index aeb9e1800f71..0201c6776746 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -95,6 +95,16 @@ vreg_nvme: regulator-nvme {
regulator-boot-on;
};
+ vreg_vph_pwr: regulator-vph-pwr {
+ compatible = "regulator-fixed";
+
+ regulator-name = "VPH_VCC3R9";
+ regulator-min-microvolt = <3900000>;
+ regulator-max-microvolt = <3900000>;
+
+ regulator-always-on;
+ };
+
vreg_wlan: regulator-wlan {
compatible = "regulator-fixed";
@@ -127,14 +137,6 @@ vreg_wwan: regulator-wwan {
regulator-boot-on;
};
- vreg_vph_pwr: regulator-vph-pwr {
- compatible = "regulator-fixed";
- regulator-name = "VPH_VCC3R9";
- regulator-min-microvolt = <3900000>;
- regulator-max-microvolt = <3900000>;
- regulator-always-on;
- };
-
thermal-zones {
skin-temp-thermal {
polling-delay-passive = <250>;
--
2.37.4
On Wed, 28 Dec 2022 09:56:14 +0100, Johan Hovold wrote: > Move the new 'regulator-vph-pwr' node before the wlan regulator node to > restore the root-node sort order (alphabetically by node name). > > While at it, add a couple of newlines to separate the properties for > consistency with the other regulator nodes. > > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sc8280xp-x13s: move 'regulator-vph-pwr' node commit: 3abf1f5c18a3f5a8da7f858e0aa5926e59575b1b Best regards, -- Bjorn Andersson <andersson@kernel.org>
On 28.12.2022 09:56, Johan Hovold wrote: > Move the new 'regulator-vph-pwr' node before the wlan regulator node to > restore the root-node sort order (alphabetically by node name). > > While at it, add a couple of newlines to separate the properties for > consistency with the other regulator nodes. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index aeb9e1800f71..0201c6776746 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -95,6 +95,16 @@ vreg_nvme: regulator-nvme { > regulator-boot-on; > }; > > + vreg_vph_pwr: regulator-vph-pwr { > + compatible = "regulator-fixed"; > + > + regulator-name = "VPH_VCC3R9"; > + regulator-min-microvolt = <3900000>; > + regulator-max-microvolt = <3900000>; > + > + regulator-always-on; > + }; > + > vreg_wlan: regulator-wlan { > compatible = "regulator-fixed"; > > @@ -127,14 +137,6 @@ vreg_wwan: regulator-wwan { > regulator-boot-on; > }; > > - vreg_vph_pwr: regulator-vph-pwr { > - compatible = "regulator-fixed"; > - regulator-name = "VPH_VCC3R9"; > - regulator-min-microvolt = <3900000>; > - regulator-max-microvolt = <3900000>; > - regulator-always-on; > - }; > - > thermal-zones { > skin-temp-thermal { > polling-delay-passive = <250>;
© 2016 - 2025 Red Hat, Inc.