drivers/misc/ocxl/context.c : eliminate unnecessary type conversions

[PATCH] drivers/misc/ocxl/context.c : eliminate unnecessary type conversions

Posted by Dong Chuanjian 2 years, 8 months ago

remove unnecessary void* type casting.

Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>

diff --git a/drivers/misc/ocxl/context.c b/drivers/misc/ocxl/context.c
index 9eb0d93b01c6..d6e081812300 100644
--- a/drivers/misc/ocxl/context.c
+++ b/drivers/misc/ocxl/context.c
@@ -55,7 +55,7 @@ EXPORT_SYMBOL_GPL(ocxl_context_alloc);
  */
 static void xsl_fault_error(void *data, u64 addr, u64 dsisr)
 {
-	struct ocxl_context *ctx = (struct ocxl_context *) data;
+	struct ocxl_context *ctx = data;
 
 	mutex_lock(&ctx->xsl_error_lock);
 	ctx->xsl_error.addr = addr;
-- 
2.18.2

Re: [PATCH] drivers/misc/ocxl/context.c : eliminate unnecessary type conversions

Posted by Greg KH 2 years, 8 months ago

On Mon, Dec 26, 2022 at 10:51:45AM +0800, Dong Chuanjian wrote:
> remove unnecessary void* type casting.

That says what you did, but not why you did it.  Please read the
documentation for how to write good changelog texts.

thanks,

greg k-h

Re: [PATCH] drivers/misc/ocxl/context.c : eliminate unnecessary type conversions

Posted by Andrew Donnellan 2 years, 8 months ago

On Mon, 2022-12-26 at 10:51 +0800, Dong Chuanjian wrote:
> remove unnecessary void* type casting.
> 
> Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>


[+linuxppc-dev, which was misspelled in the original email]

Acked-by: Andrew Donnellan <ajd@linux.ibm.com>

> 
> diff --git a/drivers/misc/ocxl/context.c
> b/drivers/misc/ocxl/context.c
> index 9eb0d93b01c6..d6e081812300 100644
> --- a/drivers/misc/ocxl/context.c
> +++ b/drivers/misc/ocxl/context.c
> @@ -55,7 +55,7 @@ EXPORT_SYMBOL_GPL(ocxl_context_alloc);
>   */
>  static void xsl_fault_error(void *data, u64 addr, u64 dsisr)
>  {
> -       struct ocxl_context *ctx = (struct ocxl_context *) data;
> +       struct ocxl_context *ctx = data;
>  
>         mutex_lock(&ctx->xsl_error_lock);
>         ctx->xsl_error.addr = addr;

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited