arm64: dts: imx8mm-evk: update leds node

[PATCH] arm64: dts: imx8mm-evk: update leds node

Posted by Peng Fan (OSS) 2 years, 8 months ago

From: Peng Fan <peng.fan@nxp.com>

Drop deprecated label property, update node name as leds-gpio.yaml

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
index e0b604ac0da4..0f87991dcb57 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
@@ -24,8 +24,7 @@ leds {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_gpio_led>;
 
-		status {
-			label = "status";
+		led-0 {
 			gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
 			default-state = "on";
 		};
-- 
2.37.1

Re: [PATCH] arm64: dts: imx8mm-evk: update leds node

Posted by Pavel Machek 2 years, 8 months ago

On Fri 2022-12-23 11:02:27, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Drop deprecated label property, update node name as leds-gpio.yaml
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index e0b604ac0da4..0f87991dcb57 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -24,8 +24,7 @@ leds {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_gpio_led>;
>  
> -		status {
> -			label = "status";
> +		led-0 {
>  			gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
>  			default-state = "on";
>  		};

Please cc led lists on led changes.

And don't do this, this will change userland interface.
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Re: [PATCH] arm64: dts: imx8mm-evk: update leds node

Posted by Marco Felsch 2 years, 8 months ago

Hi Peng,

On 22-12-23, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Drop deprecated label property, update node name as leds-gpio.yaml
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index e0b604ac0da4..0f87991dcb57 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -24,8 +24,7 @@ leds {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_gpio_led>;
>  
> -		status {
> -			label = "status";
> +		led-0 {

We can use just 'led' since this is a single led.

Regards,
  Marco

>  			gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
>  			default-state = "on";
>  		};
> -- 
> 2.37.1
> 
> 
>