Input: synaptics-rmi4: Fix SPI device ID

[PATCH] Input: synaptics-rmi4: Fix SPI device ID

Posted by Rayyan Ansari 2 years, 9 months ago

Currently, the ID being set to "rmi4_spi" causes this warning:
"SPI driver rmi4_spi has no spi_device_id for syna,rmi4-spi"

Change the ID to rmi4-spi to stop this warning.

Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
---
 drivers/input/rmi4/rmi_spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/rmi4/rmi_spi.c b/drivers/input/rmi4/rmi_spi.c
index c82edda66b23..aa3a6a8544d4 100644
--- a/drivers/input/rmi4/rmi_spi.c
+++ b/drivers/input/rmi4/rmi_spi.c
@@ -510,7 +510,7 @@ static const struct dev_pm_ops rmi_spi_pm = {
 };
 
 static const struct spi_device_id rmi_id[] = {
-	{ "rmi4_spi", 0 },
+	{ "rmi4-spi", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, rmi_id);
-- 
2.39.0

Re: [PATCH] Input: synaptics-rmi4: Fix SPI device ID

Posted by Dmitry Torokhov 2 years, 7 months ago

On Mon, Dec 19, 2022 at 01:37:15PM +0000, Rayyan Ansari wrote:
> Currently, the ID being set to "rmi4_spi" causes this warning:
> "SPI driver rmi4_spi has no spi_device_id for syna,rmi4-spi"
> 
> Change the ID to rmi4-spi to stop this warning.
> 
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>

Applied, thank you.

-- 
Dmitry

Re: [PATCH] Input: synaptics-rmi4: Fix SPI device ID

Posted by Mattijs Korpershoek 2 years, 7 months ago

On Mon, Dec 19, 2022 at 13:37, Rayyan Ansari <rayyan@ansari.sh> wrote:

> Currently, the ID being set to "rmi4_spi" causes this warning:
> "SPI driver rmi4_spi has no spi_device_id for syna,rmi4-spi"
>
> Change the ID to rmi4-spi to stop this warning.
>
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  drivers/input/rmi4/rmi_spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_spi.c b/drivers/input/rmi4/rmi_spi.c
> index c82edda66b23..aa3a6a8544d4 100644
> --- a/drivers/input/rmi4/rmi_spi.c
> +++ b/drivers/input/rmi4/rmi_spi.c
> @@ -510,7 +510,7 @@ static const struct dev_pm_ops rmi_spi_pm = {
>  };
>  
>  static const struct spi_device_id rmi_id[] = {
> -	{ "rmi4_spi", 0 },
> +	{ "rmi4-spi", 0 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(spi, rmi_id);
> -- 
> 2.39.0