[PATCH V2] scripts: kconfig: Corrected the misspelled word in kconfig help text

Bhaskar Chowdhury posted 1 patch 2 years, 9 months ago
scripts/kconfig/mconf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH V2] scripts: kconfig: Corrected the misspelled word in kconfig help text
Posted by Bhaskar Chowdhury 2 years, 9 months ago
s/sash/slash/

Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
 Changes from V1: corrected the misspelled word
 scripts/kconfig/mconf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index 93dc4850ff2a..a82cac8916ab 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -164,7 +164,7 @@ static const char mconf_readme[] =

 "Search\n"
 "------\n"
-"Press forward sash(/) anywhere will bring up search dialog box\n"
+"Press forward slash(/) anywhere will bring up search dialog box\n"
 "\n"

 "Different color themes available\n"
--
2.38.1
Re: [PATCH V2] scripts: kconfig: Corrected the misspelled word in kconfig help text
Posted by Randy Dunlap 2 years, 9 months ago

On 12/16/22 19:59, Bhaskar Chowdhury wrote:
> s/sash/slash/
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
>  Changes from V1: corrected the misspelled word

V2 should be a full patch, not just a correction to V1.
IF V1 were applied, then this patch could be applicable,
but then it would be patch 2/2, not just V2.


>  scripts/kconfig/mconf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 93dc4850ff2a..a82cac8916ab 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -164,7 +164,7 @@ static const char mconf_readme[] =
> 
>  "Search\n"
>  "------\n"
> -"Press forward sash(/) anywhere will bring up search dialog box\n"
> +"Press forward slash(/) anywhere will bring up search dialog box\n"
>  "\n"
> 
>  "Different color themes available\n"
> --
> 2.38.1
> 

-- 
~Randy
Re: [PATCH V2] scripts: kconfig: Corrected the misspelled word in kconfig help text
Posted by Randy Dunlap 2 years, 9 months ago
Hi--

On 12/16/22 19:59, Bhaskar Chowdhury wrote:
> s/sash/slash/
> 

That correction is good...

> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
>  Changes from V1: corrected the misspelled word
>  scripts/kconfig/mconf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 93dc4850ff2a..a82cac8916ab 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -164,7 +164,7 @@ static const char mconf_readme[] =
> 
>  "Search\n"
>  "------\n"
> -"Press forward sash(/) anywhere will bring up search dialog box\n"
> +"Press forward slash(/) anywhere will bring up search dialog box\n"

That sentence could be better. Either
s/Press/Pressing/
or
s/will/to/
but not both of those -- just one of them.
And then s/bring up/bring up a/.

>  "\n"
> 
>  "Different color themes available\n"
> --
> 2.38.1
> 

Thanks.
-- 
~Randy