[PATCH v4 1/1] dt-bindings: mfd: x-powers,axp152: Document the AXP1530 variant

Martin Botka posted 3 patches 2 years, 9 months ago
There is a newer version of this series
[PATCH v4 1/1] dt-bindings: mfd: x-powers,axp152: Document the AXP1530 variant
Posted by Martin Botka 2 years, 9 months ago
AXP1530 is a PMIC used on board BIQU CB1 SoM

Signed-off-by: Martin Botka <martin.botka@somainline.org>
---
 Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
index b7a8747d5fa0..7559a13a071c 100644
--- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
+++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
@@ -84,6 +84,7 @@ properties:
     oneOf:
       - enum:
           - x-powers,axp152
+          - x-powers,axp1530
           - x-powers,axp202
           - x-powers,axp209
           - x-powers,axp221
-- 
2.38.1
Re: [PATCH v4 1/1] dt-bindings: mfd: x-powers,axp152: Document the AXP1530 variant
Posted by Krzysztof Kozlowski 2 years, 9 months ago
On 13/12/2022 19:27, Martin Botka wrote:
> AXP1530 is a PMIC used on board BIQU CB1 SoM
> 
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> ---
>  Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 1 +

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof
Re: [PATCH v4 1/1] dt-bindings: mfd: x-powers,axp152: Document the AXP1530 variant
Posted by Martin Botka 2 years, 9 months ago
That is very much my bad.

I understand the purpose of them :)

I just straight up forgot to add them.
There is also ordering issue in mfd patch which was forgotten as well and was meant to be included in v4.
This ordering was corrected in regulators patch so i do apologize.

I will be sending v5 in a day or two with your ack included and this corrected and other comments that may show up during this time.

Thank you.
Best regards,
Martin

On December 13, 2022 8:37:48 PM GMT+01:00, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>On 13/12/2022 19:27, Martin Botka wrote:
>> AXP1530 is a PMIC used on board BIQU CB1 SoM
>> 
>> Signed-off-by: Martin Botka <martin.botka@somainline.org>
>> ---
>>  Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 1 +
>
>This is a friendly reminder during the review process.
>
>It looks like you received a tag and forgot to add it.
>
>If you do not know the process, here is a short explanation:
>Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>versions. However, there's no need to repost patches *only* to add the
>tags. The upstream maintainer will do that for acks received on the
>version they apply.
>
>https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>
>If a tag was not added on purpose, please state why and what changed.
>
>Best regards,
>Krzysztof
>
Re: [PATCH v4 1/1] dt-bindings: mfd: x-powers,axp152: Document the AXP1530 variant
Posted by Krzysztof Kozlowski 2 years, 9 months ago
On 13/12/2022 20:43, Martin Botka wrote:
> That is very much my bad.
> 
> I understand the purpose of them :)
> 
> I just straight up forgot to add them.

Sure, happens, no worries.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof