gpiolib: use irq_domain_alloc_irqs()

[PATCH] gpiolib: use irq_domain_alloc_irqs()

Posted by Johan Hovold 2 years, 9 months ago

Use the irq_domain_alloc_irqs() wrapper instead of the full
__irq_domain_alloc_irqs() interface, which was only intended for some
legacy (x86) use cases.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/gpio/gpiolib.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 5a66d9616d7c..ede9630b197c 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1126,14 +1126,8 @@ static void gpiochip_set_hierarchical_irqchip(struct gpio_chip *gc,
 			/* Just pick something */
 			fwspec.param[1] = IRQ_TYPE_EDGE_RISING;
 			fwspec.param_count = 2;
-			ret = __irq_domain_alloc_irqs(gc->irq.domain,
-						      /* just pick something */
-						      -1,
-						      1,
-						      NUMA_NO_NODE,
-						      &fwspec,
-						      false,
-						      NULL);
+			ret = irq_domain_alloc_irqs(gc->irq.domain, 1,
+						    NUMA_NO_NODE, &fwspec);
 			if (ret < 0) {
 				chip_err(gc,
 					 "can not allocate irq for GPIO line %d parent hwirq %d in hierarchy domain: %d\n",
-- 
2.37.4

Re: [PATCH] gpiolib: use irq_domain_alloc_irqs()

Posted by Bartosz Golaszewski 2 years, 8 months ago

On Tue, Dec 13, 2022 at 2:52 PM Johan Hovold <johan+linaro@kernel.org> wrote:
>
> Use the irq_domain_alloc_irqs() wrapper instead of the full
> __irq_domain_alloc_irqs() interface, which was only intended for some
> legacy (x86) use cases.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  drivers/gpio/gpiolib.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 5a66d9616d7c..ede9630b197c 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1126,14 +1126,8 @@ static void gpiochip_set_hierarchical_irqchip(struct gpio_chip *gc,
>                         /* Just pick something */
>                         fwspec.param[1] = IRQ_TYPE_EDGE_RISING;
>                         fwspec.param_count = 2;
> -                       ret = __irq_domain_alloc_irqs(gc->irq.domain,
> -                                                     /* just pick something */
> -                                                     -1,
> -                                                     1,
> -                                                     NUMA_NO_NODE,
> -                                                     &fwspec,
> -                                                     false,
> -                                                     NULL);
> +                       ret = irq_domain_alloc_irqs(gc->irq.domain, 1,
> +                                                   NUMA_NO_NODE, &fwspec);
>                         if (ret < 0) {
>                                 chip_err(gc,
>                                          "can not allocate irq for GPIO line %d parent hwirq %d in hierarchy domain: %d\n",
> --
> 2.37.4
>

Applied, thanks!

Bart

Re: [PATCH] gpiolib: use irq_domain_alloc_irqs()

Posted by Linus Walleij 2 years, 9 months ago

On Tue, Dec 13, 2022 at 2:52 PM Johan Hovold <johan+linaro@kernel.org> wrote:

> Use the irq_domain_alloc_irqs() wrapper instead of the full
> __irq_domain_alloc_irqs() interface, which was only intended for some
> legacy (x86) use cases.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Also semantically identical as can be seen from <linux/irqdomain.h>
I don't know what I was thinking.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij