fuse: remove duplicate check for nodeid

[PATCH] fuse: remove duplicate check for nodeid

Posted by zyfjeff 2 years, 9 months ago

before this check, the nodeid has already been checked once, so
the check here doesn't make an sense, so remove the check for
nodeid here.

            if (err || !outarg->nodeid)
                    goto out_put_forget;

            err = -EIO;
    >>>     if (!outarg->nodeid)
                    goto out_put_forget;

Signed-off-by: zyfjeff <zyfjeff@linux.alibaba.com>
---
 fs/fuse/dir.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index cd1a071b625a..a33cd1131640 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -395,8 +395,6 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, const struct qstr *name
 		goto out_put_forget;
 
 	err = -EIO;
-	if (!outarg->nodeid)
-		goto out_put_forget;
 	if (fuse_invalid_attr(&outarg->attr))
 		goto out_put_forget;
 
-- 
2.34.0

Re: [PATCH] fuse: remove duplicate check for nodeid

Posted by Miklos Szeredi 2 years, 7 months ago

On Tue, 13 Dec 2022 at 12:52, zyfjeff <zyfjeff@linux.alibaba.com> wrote:
>
> before this check, the nodeid has already been checked once, so
> the check here doesn't make an sense, so remove the check for
> nodeid here.
>
>             if (err || !outarg->nodeid)
>                     goto out_put_forget;
>
>             err = -EIO;
>     >>>     if (!outarg->nodeid)
>                     goto out_put_forget;
>
> Signed-off-by: zyfjeff <zyfjeff@linux.alibaba.com>

Applied, thanks.

Miklos