power: supply: cros_usbpd: reclassify "default case!" as debug

[PATCH] power: supply: cros_usbpd: reclassify "default case!" as debug

Posted by Grant Grundler 2 years, 9 months ago

This doesn't need to be printed every second as an error:
...
<3>[17438.628385] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case!
<3>[17439.634176] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case!
<3>[17440.640298] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case!
...

Reduce priority from ERROR to DEBUG.

Signed-off-by: Grant Grundler <grundler@chromium.org>
---
 drivers/power/supply/cros_usbpd-charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/supply/cros_usbpd-charger.c b/drivers/power/supply/cros_usbpd-charger.c
index cadb6a0c2cc7..b6c96376776a 100644
--- a/drivers/power/supply/cros_usbpd-charger.c
+++ b/drivers/power/supply/cros_usbpd-charger.c
@@ -276,7 +276,7 @@ static int cros_usbpd_charger_get_power_info(struct port_data *port)
 		port->psy_current_max = 0;
 		break;
 	default:
-		dev_err(dev, "Port %d: default case!\n", port->port_number);
+		dev_dbg(dev, "Port %d: default case!\n", port->port_number);
 		port->psy_usb_type = POWER_SUPPLY_USB_TYPE_SDP;
 	}
 
-- 
2.39.0.rc1.256.g54fd8350bd-goog

Re: [PATCH] power: supply: cros_usbpd: reclassify "default case!" as debug

Posted by Guenter Roeck 2 years, 9 months ago

On Mon, Dec 12, 2022 at 1:39 PM Grant Grundler <grundler@chromium.org> wrote:
>
> This doesn't need to be printed every second as an error:
> ...
> <3>[17438.628385] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case!
> <3>[17439.634176] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case!
> <3>[17440.640298] cros-usbpd-charger cros-usbpd-charger.3.auto: Port 1: default case!
> ...
>
> Reduce priority from ERROR to DEBUG.
>
> Signed-off-by: Grant Grundler <grundler@chromium.org>

Reviewed-by: Guenter Roeck <groeck@chromium.org>

>
> ---
>  drivers/power/supply/cros_usbpd-charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/cros_usbpd-charger.c b/drivers/power/supply/cros_usbpd-charger.c
> index cadb6a0c2cc7..b6c96376776a 100644
> --- a/drivers/power/supply/cros_usbpd-charger.c
> +++ b/drivers/power/supply/cros_usbpd-charger.c
> @@ -276,7 +276,7 @@ static int cros_usbpd_charger_get_power_info(struct port_data *port)
>                 port->psy_current_max = 0;
>                 break;
>         default:
> -               dev_err(dev, "Port %d: default case!\n", port->port_number);
> +               dev_dbg(dev, "Port %d: default case!\n", port->port_number);
>                 port->psy_usb_type = POWER_SUPPLY_USB_TYPE_SDP;
>         }
>
> --
> 2.39.0.rc1.256.g54fd8350bd-goog
>