drivers/net/dsa/lan9303-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
This patch fixes an issue where a read failure of a port statistic counter
will return unknown results. While it is highly unlikely the read will
ever fail, it is much cleaner to return a zero for the stat count.
Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")
Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
---
v1->v2:
corrected email header: net vs net-next, Added 1 maintainer, removed
blank line.
No changes to the body of the patch.
---
drivers/net/dsa/lan9303-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
index 80f07bd20593..2e270b479143 100644
--- a/drivers/net/dsa/lan9303-core.c
+++ b/drivers/net/dsa/lan9303-core.c
@@ -1005,9 +1005,11 @@ static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port,
ret = lan9303_read_switch_port(
chip, port, lan9303_mib[u].offset, ®);
- if (ret)
+ if (ret) {
dev_warn(chip->dev, "Reading status port %d reg %u failed\n",
port, lan9303_mib[u].offset);
+ reg = 0;
+ }
data[u] = reg;
}
}
--
2.17.1
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Fri, 9 Dec 2022 09:35:02 -0600 you wrote: > This patch fixes an issue where a read failure of a port statistic counter > will return unknown results. While it is highly unlikely the read will > ever fail, it is much cleaner to return a zero for the stat count. > > Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303") > Signed-off-by: Jerry Ray <jerry.ray@microchip.com> > > [...] Here is the summary with links: - [v2] net: lan9303: Fix read error execution path https://git.kernel.org/netdev/net/c/8964916d2060 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
On 12/9/22 07:35, Jerry Ray wrote: > This patch fixes an issue where a read failure of a port statistic counter > will return unknown results. While it is highly unlikely the read will > ever fail, it is much cleaner to return a zero for the stat count. > > Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303") > Signed-off-by: Jerry Ray <jerry.ray@microchip.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
On Fri, Dec 09, 2022 at 09:35:02AM -0600, Jerry Ray wrote: > This patch fixes an issue where a read failure of a port statistic counter > will return unknown results. While it is highly unlikely the read will > ever fail, it is much cleaner to return a zero for the stat count. > > Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303") > Signed-off-by: Jerry Ray <jerry.ray@microchip.com> > --- > v1->v2: > corrected email header: net vs net-next, Added 1 maintainer, removed > blank line. Actually it's not "net vs net-next", but rather, "nothing vs net-next". As you can see, the patchwork CI complains that "Target tree name [is] not specified in the subject". https://patchwork.kernel.org/project/netdevbpf/patch/20221209153502.7429-1-jerry.ray@microchip.com/ Anyway, I think it's quite obvious for maintainers that it's a patch intended for the net.git tree, so there isn't a reason to resend this patch, just something to know and to do better in the future. > No changes to the body of the patch. > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
© 2016 - 2025 Red Hat, Inc.