1. Patchew
  2. linux
  3. [PATCH v2 0/4] amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9
  4. View patch

[PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850

Sriranjani P posted 4 patches 2 years, 9 months ago
There is a newer version of this series
[PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
Posted by Sriranjani P 2 years, 9 months ago 
Exynos850 has two different SYSREGs, hence add dedicated compatibles for
them and deprecate usage of generic Exynos850 compatible alone.

Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
---
 .../soc/samsung/samsung,exynos-sysreg.yaml        | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 4954790eda6c..a37452965100 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -17,7 +17,6 @@ properties:
               - samsung,exynos3-sysreg
               - samsung,exynos4-sysreg
               - samsung,exynos5-sysreg
-              - samsung,exynos850-sysreg
               - samsung,exynosautov9-sysreg
               - tesla,fsd-cam-sysreg
               - tesla,fsd-fsys0-sysreg
@@ -33,9 +32,17 @@ properties:
           - const: samsung,exynos5433-sysreg
           - const: syscon
       - items:
-          - const: samsung,exynos5433-sysreg
+          - enum:
+              - const: samsung,exynos5433-sysreg
+              - const: samsung,exynos850-sysreg
+              - const: syscon
+            deprecated: true
+      - items:
+          - enum:
+              - samsung,exynos850-cmgp-sysreg
+              - samsung,exynos850-peri-sysreg
+          - const: samsung,exynos850-sysreg
           - const: syscon
-        deprecated: true
 
   reg:
     maxItems: 1
@@ -53,6 +60,8 @@ allOf:
         compatible:
           contains:
             enum:
+              - samsung,exynos850-cmgp-sysreg
+              - samsung,exynos850-peri-sysreg
               - samsung,exynos850-sysreg
     then:
       required:
-- 
2.17.1
Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
Posted by Rob Herring 2 years, 9 months ago 
On Wed, Dec 07, 2022 at 04:20:29PM +0530, Sriranjani P wrote:
> Exynos850 has two different SYSREGs, hence add dedicated compatibles for
> them and deprecate usage of generic Exynos850 compatible alone.
> 
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> ---
>  .../soc/samsung/samsung,exynos-sysreg.yaml        | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 4954790eda6c..a37452965100 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -17,7 +17,6 @@ properties:
>                - samsung,exynos3-sysreg
>                - samsung,exynos4-sysreg
>                - samsung,exynos5-sysreg
> -              - samsung,exynos850-sysreg
>                - samsung,exynosautov9-sysreg
>                - tesla,fsd-cam-sysreg
>                - tesla,fsd-fsys0-sysreg
> @@ -33,9 +32,17 @@ properties:
>            - const: samsung,exynos5433-sysreg
>            - const: syscon
>        - items:
> -          - const: samsung,exynos5433-sysreg
> +          - enum:
> +              - const: samsung,exynos5433-sysreg

This says the compatible entry is "const: samsung,exynos5433-sysreg".

That should be a schema warning. You did test this, right?

Rob
RE: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
Posted by Sriranjani P 2 years, 9 months ago 

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 10 December 2022 02:40
> To: Sriranjani P <sriranjani.p@samsung.com>
> Cc: krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org;
> alim.akhtar@samsung.com; pankaj.dubey@samsung.com;
> ravi.patel@samsung.com; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org
> Subject: Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add
> dedicated SYSREG compatibles to Exynos850
> 
> On Wed, Dec 07, 2022 at 04:20:29PM +0530, Sriranjani P wrote:
> > Exynos850 has two different SYSREGs, hence add dedicated compatibles
> > for them and deprecate usage of generic Exynos850 compatible alone.
> >
> > Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> > ---
> >  .../soc/samsung/samsung,exynos-sysreg.yaml        | 15 ++++++++++++---
> >  1 file changed, 12 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.
> > yaml
> > b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.
> > yaml index 4954790eda6c..a37452965100 100644
> > ---
> > a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.
> > yaml
> > +++
> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sys
> > +++ reg.yaml
> > @@ -17,7 +17,6 @@ properties:
> >                - samsung,exynos3-sysreg
> >                - samsung,exynos4-sysreg
> >                - samsung,exynos5-sysreg
> > -              - samsung,exynos850-sysreg
> >                - samsung,exynosautov9-sysreg
> >                - tesla,fsd-cam-sysreg
> >                - tesla,fsd-fsys0-sysreg @@ -33,9 +32,17 @@ properties:
> >            - const: samsung,exynos5433-sysreg
> >            - const: syscon
> >        - items:
> > -          - const: samsung,exynos5433-sysreg
> > +          - enum:
> > +              - const: samsung,exynos5433-sysreg
> 
> This says the compatible entry is "const: samsung,exynos5433-sysreg".
> 
> That should be a schema warning. You did test this, right?
Thanks for pointing it out, somehow dtbs check not showed any error. Will
fix it in the next version.
> 
> Rob
Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
Posted by Krzysztof Kozlowski 2 years, 9 months ago 
On 14/12/2022 05:41, Sriranjani P wrote:
> 
> 
>> -----Original Message-----
>> From: Rob Herring [mailto:robh@kernel.org]
>> Sent: 10 December 2022 02:40
>> To: Sriranjani P <sriranjani.p@samsung.com>
>> Cc: krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org;
>> alim.akhtar@samsung.com; pankaj.dubey@samsung.com;
>> ravi.patel@samsung.com; linux-kernel@vger.kernel.org; linux-arm-
>> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org
>> Subject: Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add
>> dedicated SYSREG compatibles to Exynos850
>>
>> On Wed, Dec 07, 2022 at 04:20:29PM +0530, Sriranjani P wrote:
>>> Exynos850 has two different SYSREGs, hence add dedicated compatibles
>>> for them and deprecate usage of generic Exynos850 compatible alone.
>>>
>>> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
>>> ---
>>>  .../soc/samsung/samsung,exynos-sysreg.yaml        | 15 ++++++++++++---
>>>  1 file changed, 12 insertions(+), 3 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.
>>> yaml
>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.
>>> yaml index 4954790eda6c..a37452965100 100644
>>> ---
>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.
>>> yaml
>>> +++
>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sys
>>> +++ reg.yaml
>>> @@ -17,7 +17,6 @@ properties:
>>>                - samsung,exynos3-sysreg
>>>                - samsung,exynos4-sysreg
>>>                - samsung,exynos5-sysreg
>>> -              - samsung,exynos850-sysreg
>>>                - samsung,exynosautov9-sysreg
>>>                - tesla,fsd-cam-sysreg
>>>                - tesla,fsd-fsys0-sysreg @@ -33,9 +32,17 @@ properties:
>>>            - const: samsung,exynos5433-sysreg
>>>            - const: syscon
>>>        - items:
>>> -          - const: samsung,exynos5433-sysreg
>>> +          - enum:
>>> +              - const: samsung,exynos5433-sysreg
>>
>> This says the compatible entry is "const: samsung,exynos5433-sysreg".
>>
>> That should be a schema warning. You did test this, right?
> Thanks for pointing it out, somehow dtbs check not showed any error. Will
> fix it in the next version.

To test binding please run dt_binding_check instead.

Best regards,
Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.