1. Patchew
  2. linux
  3. [PATCH v1 0/7] Add Ethernet driver for StarFive JH7110 SoC
  4. View patch

[PATCH v1 1/7] dt-bindings: net: snps,dwmac: Add compatible string for dwmac-5.20 version.

Yanhong Wang posted 7 patches 2 years, 9 months ago
There is a newer version of this series
[PATCH v1 1/7] dt-bindings: net: snps,dwmac: Add compatible string for dwmac-5.20 version.
Posted by Yanhong Wang 2 years, 9 months ago 
Add dwmac-5.20 version to snps.dwmac.yaml

Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
---
 Documentation/devicetree/bindings/net/snps,dwmac.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 13b984076af5..d8779d3de3d6 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -30,6 +30,7 @@ select:
           - snps,dwmac-4.10a
           - snps,dwmac-4.20a
           - snps,dwmac-5.10a
+          - snps,dwmac-5.20
           - snps,dwxgmac
           - snps,dwxgmac-2.10
 
-- 
2.17.1
Re: [PATCH v1 1/7] dt-bindings: net: snps,dwmac: Add compatible string for dwmac-5.20 version.
Posted by Krzysztof Kozlowski 2 years, 9 months ago 
On 01/12/2022 10:02, Yanhong Wang wrote:
> Add dwmac-5.20 version to snps.dwmac.yaml

Drop full stop from subject and add it here instead.

> 
> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>

Two people contributed this one single line?

Best regards,
Krzysztof
Re: [PATCH v1 1/7] dt-bindings: net: snps,dwmac: Add compatible string for dwmac-5.20 version.
Posted by yanhong wang 2 years, 9 months ago 

On 2022/12/2 0:18, Krzysztof Kozlowski wrote:
> On 01/12/2022 10:02, Yanhong Wang wrote:
>> Add dwmac-5.20 version to snps.dwmac.yaml
> 
> Drop full stop from subject and add it here instead.
> 

Will update in the next version.

>> 
>> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
> 
> Two people contributed this one single line?
> 

Emil made this patch and I submitted it.

> Best regards,
> Krzysztof
>
Re: [PATCH v1 1/7] dt-bindings: net: snps,dwmac: Add compatible string for dwmac-5.20 version.
Posted by Krzysztof Kozlowski 2 years, 9 months ago 
On 02/12/2022 03:53, yanhong wang wrote:
> 
> 
> On 2022/12/2 0:18, Krzysztof Kozlowski wrote:
>> On 01/12/2022 10:02, Yanhong Wang wrote:
>>> Add dwmac-5.20 version to snps.dwmac.yaml
>>
>> Drop full stop from subject and add it here instead.
>>
> 
> Will update in the next version.
> 
>>>
>>> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
>>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
>>
>> Two people contributed this one single line?
>>
> 
> Emil made this patch and I submitted it.

If Emil made this patch, then your From field is incorrect.

Best regards,
Krzysztof
Re: [PATCH v1 1/7] dt-bindings: net: snps,dwmac: Add compatible string for dwmac-5.20 version.
Posted by Emil Renner Berthing 2 years, 9 months ago 
On Fri, 2 Dec 2022 at 09:04, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 02/12/2022 03:53, yanhong wang wrote:
> >
> >
> > On 2022/12/2 0:18, Krzysztof Kozlowski wrote:
> >> On 01/12/2022 10:02, Yanhong Wang wrote:
> >>> Add dwmac-5.20 version to snps.dwmac.yaml
> >>
> >> Drop full stop from subject and add it here instead.
> >>
> >
> > Will update in the next version.
> >
> >>>
> >>> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
> >>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
> >>
> >> Two people contributed this one single line?
> >>
> >
> > Emil made this patch and I submitted it.
>
> If Emil made this patch, then your From field is incorrect.

Yes, please don't change the author of the commits you cherry-picked
from my tree.

But now I'm curious. Did you check with your colleagues that the dwmac
IP on the SoC is in fact version 5.20?
This was just an educated guess from my side.

/Emil

> Best regards,
> Krzysztof
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v1 1/7] dt-bindings: net: snps,dwmac: Add compatible string for dwmac-5.20 version.
Posted by yanhong wang 2 years, 9 months ago 

On 2022/12/7 21:56, Emil Renner Berthing wrote:
> On Fri, 2 Dec 2022 at 09:04, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 02/12/2022 03:53, yanhong wang wrote:
>> >
>> >
>> > On 2022/12/2 0:18, Krzysztof Kozlowski wrote:
>> >> On 01/12/2022 10:02, Yanhong Wang wrote:
>> >>> Add dwmac-5.20 version to snps.dwmac.yaml
>> >>
>> >> Drop full stop from subject and add it here instead.
>> >>
>> >
>> > Will update in the next version.
>> >
>> >>>
>> >>> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
>> >>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
>> >>
>> >> Two people contributed this one single line?
>> >>
>> >
>> > Emil made this patch and I submitted it.
>>
>> If Emil made this patch, then your From field is incorrect.
> 
> Yes, please don't change the author of the commits you cherry-picked
> from my tree.
> 
> But now I'm curious. Did you check with your colleagues that the dwmac
> IP on the SoC is in fact version 5.20?

I can confirm that the IP version is 5.20 on JH7110 SoC.

> This was just an educated guess from my side.
> 
> /Emil
> 
>> Best regards,
>> Krzysztof
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.