[PATCH] ARM: Remove redundant arch_cpu_idle_prepare()

Yajun Deng posted 1 patch 2 years, 9 months ago
arch/arm/kernel/process.c | 5 -----
1 file changed, 5 deletions(-)
[PATCH] ARM: Remove redundant arch_cpu_idle_prepare()
Posted by Yajun Deng 2 years, 9 months ago
arch_cpu_idle_prepare() was only called by cpu_startup_entry() and it is
just a wrapper for local_fiq_enable().

The local_fiq_enable() was already called before cpu_startup_entry().

So remove redundant arch_cpu_idle_prepare().

Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
 arch/arm/kernel/process.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index f811733a8fc5..e3f490ab95f4 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -81,11 +81,6 @@ void arch_cpu_idle(void)
 	raw_local_irq_enable();
 }
 
-void arch_cpu_idle_prepare(void)
-{
-	local_fiq_enable();
-}
-
 void arch_cpu_idle_enter(void)
 {
 	ledtrig_cpu(CPU_LED_IDLE_START);
-- 
2.25.1
Re: [PATCH] ARM: Remove redundant arch_cpu_idle_prepare()
Posted by Yajun Deng 2 years, 8 months ago
December 1, 2022 11:13 AM, "Yajun Deng" <yajun.deng@linux.dev> wrote:

> arch_cpu_idle_prepare() was only called by cpu_startup_entry() and it is
> just a wrapper for local_fiq_enable().
> 
> The local_fiq_enable() was already called before cpu_startup_entry().
> 
> So remove redundant arch_cpu_idle_prepare().
> 
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
> arch/arm/kernel/process.c | 5 -----
> 1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index f811733a8fc5..e3f490ab95f4 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -81,11 +81,6 @@ void arch_cpu_idle(void)
> raw_local_irq_enable();
> }
> 
> -void arch_cpu_idle_prepare(void)
> -{
> - local_fiq_enable();
> -}
> -
> void arch_cpu_idle_enter(void)
> {
> ledtrig_cpu(CPU_LED_IDLE_START);
> -- 
> 2.25.1

Ping.