1. Patchew
  2. linux
  3. View series

[PATCH] arm64: dts: qcom: sm6115: Add interconnect nodes

Bhupesh Sharma posted 1 patch 2 years, 9 months ago 
arch/arm64/boot/dts/qcom/sm6115.dtsi | 51 ++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
[PATCH] arm64: dts: qcom: sm6115: Add interconnect nodes
Posted by Bhupesh Sharma 2 years, 9 months ago 
Add the interconnect nodes inside SM6115 dtsi.

Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
- Based on linux-next/master
- Depends on the SM6115 dt-binding and driver patchset, which can be
  seen here: https://lore.kernel.org/linux-arm-msm/20221130103841.2266464-1-bhupesh.sharma@linaro.org/ 

 arch/arm64/boot/dts/qcom/sm6115.dtsi | 51 ++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
index e4a2440ce544..dad5ab3edf0e 100644
--- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
@@ -485,6 +485,57 @@ usb_1_hsphy: phy@1613000 {
 			status = "disabled";
 		};
 
+		snoc: interconnect@1880000 {
+			compatible = "qcom,sm6115-snoc";
+			reg = <0x01880000 0x60200>;
+			#interconnect-cells = <1>;
+			clock-names = "bus", "bus_a";
+			clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
+				 <&rpmcc RPM_SMD_SNOC_A_CLK>;
+
+			clk_virt: interconnect-clk {
+				compatible = "qcom,sm6115-clk-virt";
+				#interconnect-cells = <1>;
+				clock-names = "bus", "bus_a";
+				clocks = <&rpmcc RPM_SMD_QUP_CLK>,
+					 <&rpmcc RPM_SMD_QUP_A_CLK>;
+			};
+
+			mmnrt_virt: interconnect-mmnrt {
+				compatible = "qcom,sm6115-mmnrt-virt";
+				#interconnect-cells = <1>;
+				clock-names = "bus", "bus_a";
+				clocks = <&rpmcc RPM_SMD_MMNRT_CLK>,
+					 <&rpmcc RPM_SMD_MMNRT_A_CLK>;
+			};
+
+			mmrt_virt: interconnect-mmrt {
+				compatible = "qcom,sm6115-mmrt-virt";
+				#interconnect-cells = <1>;
+				clock-names = "bus", "bus_a";
+				clocks = <&rpmcc RPM_SMD_MMRT_CLK>,
+					 <&rpmcc RPM_SMD_MMRT_A_CLK>;
+			};
+		};
+
+		cnoc: interconnect@1900000 {
+			compatible = "qcom,sm6115-cnoc";
+			reg = <0x01900000 0x8200>;
+			#interconnect-cells = <1>;
+			clock-names = "bus", "bus_a";
+			clocks = <&rpmcc RPM_SMD_CNOC_CLK>,
+				 <&rpmcc RPM_SMD_CNOC_A_CLK>;
+		};
+
+		bimc: interconnect@4480000 {
+			compatible = "qcom,sm6115-bimc";
+			reg = <0x04480000 0x80000>;
+			#interconnect-cells = <1>;
+			clock-names = "bus", "bus_a";
+			clocks = <&rpmcc RPM_SMD_BIMC_CLK>,
+				 <&rpmcc RPM_SMD_BIMC_A_CLK>;
+		};
+
 		qfprom@1b40000 {
 			compatible = "qcom,sm6115-qfprom", "qcom,qfprom";
 			reg = <0x01b40000 0x7000>;
-- 
2.38.1
Re: [PATCH] arm64: dts: qcom: sm6115: Add interconnect nodes
Posted by Dmitry Baryshkov 2 years, 8 months ago 
On 30/11/2022 12:45, Bhupesh Sharma wrote:
> Add the interconnect nodes inside SM6115 dtsi.
> 
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> - Based on linux-next/master
> - Depends on the SM6115 dt-binding and driver patchset, which can be
>    seen here: https://lore.kernel.org/linux-arm-msm/20221130103841.2266464-1-bhupesh.sharma@linaro.org/
> 
>   arch/arm64/boot/dts/qcom/sm6115.dtsi | 51 ++++++++++++++++++++++++++++
>   1 file changed, 51 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index e4a2440ce544..dad5ab3edf0e 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -485,6 +485,57 @@ usb_1_hsphy: phy@1613000 {
>   			status = "disabled";
>   		};
>   
> +		snoc: interconnect@1880000 {
> +			compatible = "qcom,sm6115-snoc";
> +			reg = <0x01880000 0x60200>;
> +			#interconnect-cells = <1>;

Should we use 2 here as we do now for most of interconnect drivers?

> +			clock-names = "bus", "bus_a";
> +			clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
> +				 <&rpmcc RPM_SMD_SNOC_A_CLK>;

-- 
With best wishes
Dmitry
Re: [PATCH] arm64: dts: qcom: sm6115: Add interconnect nodes
Posted by Bhupesh Sharma 2 years, 8 months ago 
Hi Dmitry,

On Thu, 19 Jan 2023 at 18:36, Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On 30/11/2022 12:45, Bhupesh Sharma wrote:
> > Add the interconnect nodes inside SM6115 dtsi.
> >
> > Cc: Bjorn Andersson <andersson@kernel.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> > ---
> > - Based on linux-next/master
> > - Depends on the SM6115 dt-binding and driver patchset, which can be
> >    seen here: https://lore.kernel.org/linux-arm-msm/20221130103841.2266464-1-bhupesh.sharma@linaro.org/
> >
> >   arch/arm64/boot/dts/qcom/sm6115.dtsi | 51 ++++++++++++++++++++++++++++
> >   1 file changed, 51 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > index e4a2440ce544..dad5ab3edf0e 100644
> > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > @@ -485,6 +485,57 @@ usb_1_hsphy: phy@1613000 {
> >                       status = "disabled";
> >               };
> >
> > +             snoc: interconnect@1880000 {
> > +                     compatible = "qcom,sm6115-snoc";
> > +                     reg = <0x01880000 0x60200>;
> > +                     #interconnect-cells = <1>;
>
> Should we use 2 here as we do now for most of interconnect drivers?

Right now, we are using the value present in upstream qcs404.dtsi
which is the nearest in terms of similarity of the interconnect blocks
present on this SoC. But let me try and make this change in v2.

BTW the 'path tag' is optional, so I don't think that would be a
mandatory change.

Thanks,
Bhupesh
Re: [PATCH] arm64: dts: qcom: sm6115: Add interconnect nodes
Posted by Bjorn Andersson 2 years, 8 months ago 
On Wed, Nov 30, 2022 at 04:15:19PM +0530, Bhupesh Sharma wrote:
> Add the interconnect nodes inside SM6115 dtsi.
> 
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>

Seems the driver series is waiting for a v2.

I'll drop this from my queue for now, please resubmit once the DT
binding has landed.

Thanks,
Bjorn

> ---
> - Based on linux-next/master
> - Depends on the SM6115 dt-binding and driver patchset, which can be
>   seen here: https://lore.kernel.org/linux-arm-msm/20221130103841.2266464-1-bhupesh.sharma@linaro.org/ 
> 
>  arch/arm64/boot/dts/qcom/sm6115.dtsi | 51 ++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index e4a2440ce544..dad5ab3edf0e 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -485,6 +485,57 @@ usb_1_hsphy: phy@1613000 {
>  			status = "disabled";
>  		};
>  
> +		snoc: interconnect@1880000 {
> +			compatible = "qcom,sm6115-snoc";
> +			reg = <0x01880000 0x60200>;
> +			#interconnect-cells = <1>;
> +			clock-names = "bus", "bus_a";
> +			clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
> +				 <&rpmcc RPM_SMD_SNOC_A_CLK>;
> +
> +			clk_virt: interconnect-clk {
> +				compatible = "qcom,sm6115-clk-virt";
> +				#interconnect-cells = <1>;
> +				clock-names = "bus", "bus_a";
> +				clocks = <&rpmcc RPM_SMD_QUP_CLK>,
> +					 <&rpmcc RPM_SMD_QUP_A_CLK>;
> +			};
> +
> +			mmnrt_virt: interconnect-mmnrt {
> +				compatible = "qcom,sm6115-mmnrt-virt";
> +				#interconnect-cells = <1>;
> +				clock-names = "bus", "bus_a";
> +				clocks = <&rpmcc RPM_SMD_MMNRT_CLK>,
> +					 <&rpmcc RPM_SMD_MMNRT_A_CLK>;
> +			};
> +
> +			mmrt_virt: interconnect-mmrt {
> +				compatible = "qcom,sm6115-mmrt-virt";
> +				#interconnect-cells = <1>;
> +				clock-names = "bus", "bus_a";
> +				clocks = <&rpmcc RPM_SMD_MMRT_CLK>,
> +					 <&rpmcc RPM_SMD_MMRT_A_CLK>;
> +			};
> +		};
> +
> +		cnoc: interconnect@1900000 {
> +			compatible = "qcom,sm6115-cnoc";
> +			reg = <0x01900000 0x8200>;
> +			#interconnect-cells = <1>;
> +			clock-names = "bus", "bus_a";
> +			clocks = <&rpmcc RPM_SMD_CNOC_CLK>,
> +				 <&rpmcc RPM_SMD_CNOC_A_CLK>;
> +		};
> +
> +		bimc: interconnect@4480000 {
> +			compatible = "qcom,sm6115-bimc";
> +			reg = <0x04480000 0x80000>;
> +			#interconnect-cells = <1>;
> +			clock-names = "bus", "bus_a";
> +			clocks = <&rpmcc RPM_SMD_BIMC_CLK>,
> +				 <&rpmcc RPM_SMD_BIMC_A_CLK>;
> +		};
> +
>  		qfprom@1b40000 {
>  			compatible = "qcom,sm6115-qfprom", "qcom,qfprom";
>  			reg = <0x01b40000 0x7000>;
> -- 
> 2.38.1
>
Re: [PATCH] arm64: dts: qcom: sm6115: Add interconnect nodes
Posted by Bhupesh Sharma 2 years, 8 months ago 
On 1/19/23 5:10 AM, Bjorn Andersson wrote:
> On Wed, Nov 30, 2022 at 04:15:19PM +0530, Bhupesh Sharma wrote:
>> Add the interconnect nodes inside SM6115 dtsi.
>>
>> Cc: Bjorn Andersson <andersson@kernel.org>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> 
> Seems the driver series is waiting for a v2.
> 
> I'll drop this from my queue for now, please resubmit once the DT
> binding has landed.

Sure Bjorn. I will send a v2 shortly.

Thanks,
Bhupesh

>> ---
>> - Based on linux-next/master
>> - Depends on the SM6115 dt-binding and driver patchset, which can be
>>    seen here: https://lore.kernel.org/linux-arm-msm/20221130103841.2266464-1-bhupesh.sharma@linaro.org/
>>
>>   arch/arm64/boot/dts/qcom/sm6115.dtsi | 51 ++++++++++++++++++++++++++++
>>   1 file changed, 51 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> index e4a2440ce544..dad5ab3edf0e 100644
>> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> @@ -485,6 +485,57 @@ usb_1_hsphy: phy@1613000 {
>>   			status = "disabled";
>>   		};
>>   
>> +		snoc: interconnect@1880000 {
>> +			compatible = "qcom,sm6115-snoc";
>> +			reg = <0x01880000 0x60200>;
>> +			#interconnect-cells = <1>;
>> +			clock-names = "bus", "bus_a";
>> +			clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
>> +				 <&rpmcc RPM_SMD_SNOC_A_CLK>;
>> +
>> +			clk_virt: interconnect-clk {
>> +				compatible = "qcom,sm6115-clk-virt";
>> +				#interconnect-cells = <1>;
>> +				clock-names = "bus", "bus_a";
>> +				clocks = <&rpmcc RPM_SMD_QUP_CLK>,
>> +					 <&rpmcc RPM_SMD_QUP_A_CLK>;
>> +			};
>> +
>> +			mmnrt_virt: interconnect-mmnrt {
>> +				compatible = "qcom,sm6115-mmnrt-virt";
>> +				#interconnect-cells = <1>;
>> +				clock-names = "bus", "bus_a";
>> +				clocks = <&rpmcc RPM_SMD_MMNRT_CLK>,
>> +					 <&rpmcc RPM_SMD_MMNRT_A_CLK>;
>> +			};
>> +
>> +			mmrt_virt: interconnect-mmrt {
>> +				compatible = "qcom,sm6115-mmrt-virt";
>> +				#interconnect-cells = <1>;
>> +				clock-names = "bus", "bus_a";
>> +				clocks = <&rpmcc RPM_SMD_MMRT_CLK>,
>> +					 <&rpmcc RPM_SMD_MMRT_A_CLK>;
>> +			};
>> +		};
>> +
>> +		cnoc: interconnect@1900000 {
>> +			compatible = "qcom,sm6115-cnoc";
>> +			reg = <0x01900000 0x8200>;
>> +			#interconnect-cells = <1>;
>> +			clock-names = "bus", "bus_a";
>> +			clocks = <&rpmcc RPM_SMD_CNOC_CLK>,
>> +				 <&rpmcc RPM_SMD_CNOC_A_CLK>;
>> +		};
>> +
>> +		bimc: interconnect@4480000 {
>> +			compatible = "qcom,sm6115-bimc";
>> +			reg = <0x04480000 0x80000>;
>> +			#interconnect-cells = <1>;
>> +			clock-names = "bus", "bus_a";
>> +			clocks = <&rpmcc RPM_SMD_BIMC_CLK>,
>> +				 <&rpmcc RPM_SMD_BIMC_A_CLK>;
>> +		};
>> +
>>   		qfprom@1b40000 {
>>   			compatible = "qcom,sm6115-qfprom", "qcom,qfprom";
>>   			reg = <0x01b40000 0x7000>;
>> -- 
>> 2.38.1
>>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.