[v1] Fix UPI uncore issue on SPR

[PATCH 0/5] Fix UPI uncore issue on SPR

kan.liang@linux.intel.com posted 5 patches 2 years, 9 months ago

Diff against v1
Download series mbox

There is a newer version of this series

arch/x86/events/intel/uncore.c           |  34 ++++-
arch/x86/events/intel/uncore.h           |   4 +
arch/x86/events/intel/uncore_discovery.c |  60 ++++++---
arch/x86/events/intel/uncore_discovery.h |  14 +-
arch/x86/events/intel/uncore_snbep.c     | 158 ++++++++++++++++++-----
5 files changed, 210 insertions(+), 60 deletions(-)

Expand all Fold all

[PATCH 0/5] Fix UPI uncore issue on SPR

Posted by kan.liang@linux.intel.com 2 years, 9 months ago

From: Kan Liang <kan.liang@linux.intel.com>

The discovery table of UPI on SPR MCC is broken. The patch series is
to mitigate the issue by providing a hardcode pre-defined table.

The broken discovery table can trigger a kernel warning message, which
is overkilled. The patch series also refine the error handling code.

Kan Liang (5):
  perf/x86/uncore: Factor out uncore_device_to_die()
  perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name
  perf/x86/uncore: Ignore broken units in discovery table
  perf/x86/uncore: Add a quirk for UPI on SPR
  perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table

 arch/x86/events/intel/uncore.c           |  34 ++++-
 arch/x86/events/intel/uncore.h           |   4 +
 arch/x86/events/intel/uncore_discovery.c |  60 ++++++---
 arch/x86/events/intel/uncore_discovery.h |  14 +-
 arch/x86/events/intel/uncore_snbep.c     | 158 ++++++++++++++++++-----
 5 files changed, 210 insertions(+), 60 deletions(-)

-- 
2.35.1

Re: [PATCH 0/5] Fix UPI uncore issue on SPR

Posted by Liang, Kan 2 years, 8 months ago

Hi Peter,

Happy new year!

Gentle Ping. Please let me know if you have any comments on the patch set.

Thanks,
Kan

On 2022-11-29 2:10 p.m., kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
> 
> The discovery table of UPI on SPR MCC is broken. The patch series is
> to mitigate the issue by providing a hardcode pre-defined table.
> 
> The broken discovery table can trigger a kernel warning message, which
> is overkilled. The patch series also refine the error handling code.
> 
> Kan Liang (5):
>   perf/x86/uncore: Factor out uncore_device_to_die()
>   perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name
>   perf/x86/uncore: Ignore broken units in discovery table
>   perf/x86/uncore: Add a quirk for UPI on SPR
>   perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table
> 
>  arch/x86/events/intel/uncore.c           |  34 ++++-
>  arch/x86/events/intel/uncore.h           |   4 +
>  arch/x86/events/intel/uncore_discovery.c |  60 ++++++---
>  arch/x86/events/intel/uncore_discovery.h |  14 +-
>  arch/x86/events/intel/uncore_snbep.c     | 158 ++++++++++++++++++-----
>  5 files changed, 210 insertions(+), 60 deletions(-)
>