[PATCH 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property)

Jonathan Neuschäfer posted 2 patches 2 years, 9 months ago
There is a newer version of this series
[PATCH 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property)
Posted by Jonathan Neuschäfer 2 years, 9 months ago
I forgot to add a "reg = <0>;" property to the flash@0 node while
writing the example. Fix this.

Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
index e4162845fcc1d..4e0d391e1d697 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
+++ b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
@@ -56,6 +56,7 @@ examples:

       flash@0 {
         compatible = "jedec,spi-nor";
+        reg = <0>;
       };
     };

--
2.35.1
Re: [PATCH 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property)
Posted by Krzysztof Kozlowski 2 years, 9 months ago
On 28/11/2022 22:49, Jonathan Neuschäfer wrote:
> I forgot to add a "reg = <0>;" property to the flash@0 node while
> writing the example. Fix this.

Don't be personal in commit messages. Instead:
   Add missing "reg = <0>;" property to the flash@0 node in the example.

which has the same amount of information and is even shorter.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

> 
> Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>


Best regards,
Krzysztof