mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2

[PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2

Posted by Arınç ÜNAL 1 year, 9 months ago

The phy-mode property must be defined on the MAC instead of the PHY. Define
phy-mode under gmac1 which the external phy is connected to.

Tested-by: Petr Louda <petr.louda@outlook.cz>
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts b/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
index 7515555388ae..e31417569e09 100644
--- a/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
+++ b/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
@@ -113,13 +113,13 @@ &pcie {
 
 &gmac1 {
 	status = "okay";
+	phy-mode = "rgmii-rxid";
 	phy-handle = <&ethphy5>;
 };
 
 &mdio {
 	ethphy5: ethernet-phy@5 {
 		reg = <5>;
-		phy-mode = "rgmii-rxid";
 	};
 };
 
-- 
2.34.1

Re: [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2

Posted by Thomas Bogendoerfer 1 year, 9 months ago

On Tue, Nov 29, 2022 at 12:32:38AM +0300, Arınç ÜNAL wrote:
> The phy-mode property must be defined on the MAC instead of the PHY. Define
> phy-mode under gmac1 which the external phy is connected to.
> 
> Tested-by: Petr Louda <petr.louda@outlook.cz>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2

Posted by Arınç ÜNAL 1 year, 8 months ago

On 1.12.2022 13:50, Thomas Bogendoerfer wrote:
> On Tue, Nov 29, 2022 at 12:32:38AM +0300, Arınç ÜNAL wrote:
>> The phy-mode property must be defined on the MAC instead of the PHY. Define
>> phy-mode under gmac1 which the external phy is connected to.
>>
>> Tested-by: Petr Louda <petr.louda@outlook.cz>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>> ---
>>   arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> applied to mips-next.

I just realised I forgot to add "dts:" to the patch subject. Would that 
be a problem?

Arınç

Re: [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2

Posted by Sergio Paracuellos 1 year, 9 months ago

On Mon, Nov 28, 2022 at 10:33 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> The phy-mode property must be defined on the MAC instead of the PHY. Define
> phy-mode under gmac1 which the external phy is connected to.
>
> Tested-by: Petr Louda <petr.louda@outlook.cz>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Thanks,
    Sergio Paracuellos