dmaengine: ti: k3-udma: drop loglevel for non-fatal probe deferral log

[PATCH] dmaengine: ti: k3-udma: drop loglevel for non-fatal probe deferral log

Posted by Jayesh Choudhary 2 years, 9 months ago

Change the log level from dev_err() to dev_dbg() for non-fatal probe
deferral log for getting MSI domain.
This makes the kernel log clean and we do not get recurring logs
stating: "Failed to get MSI domain".

Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
 drivers/dma/ti/k3-udma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index ce8b80bb34d7..e540166cf4c7 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -5344,7 +5344,7 @@ static int udma_probe(struct platform_device *pdev)
 	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
 					    DOMAIN_BUS_TI_SCI_INTA_MSI);
 	if (!dev->msi.domain) {
-		dev_err(dev, "Failed to get MSI domain\n");
+		dev_dbg(dev, "Failed to get MSI domain\n");
 		return -EPROBE_DEFER;
 	}
 
-- 
2.25.1

Re: [PATCH] dmaengine: ti: k3-udma: drop loglevel for non-fatal probe deferral log

Posted by Péter Ujfalusi 2 years, 9 months ago


On 28/11/2022 12:13, Jayesh Choudhary wrote:
> Change the log level from dev_err() to dev_dbg() for non-fatal probe
> deferral log for getting MSI domain.
> This makes the kernel log clean and we do not get recurring logs
> stating: "Failed to get MSI domain".

Or not print at all?

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
>   drivers/dma/ti/k3-udma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index ce8b80bb34d7..e540166cf4c7 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -5344,7 +5344,7 @@ static int udma_probe(struct platform_device *pdev)
>   	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
>   					    DOMAIN_BUS_TI_SCI_INTA_MSI);
>   	if (!dev->msi.domain) {
> -		dev_err(dev, "Failed to get MSI domain\n");
> +		dev_dbg(dev, "Failed to get MSI domain\n");
>   		return -EPROBE_DEFER;
>   	}
>   

-- 
Péter

Re: [PATCH] dmaengine: ti: k3-udma: drop loglevel for non-fatal probe deferral log

Posted by Vinod Koul 2 years, 8 months ago

On 29-11-22, 18:28, Péter Ujfalusi wrote:
> 
> 
> On 28/11/2022 12:13, Jayesh Choudhary wrote:
> > Change the log level from dev_err() to dev_dbg() for non-fatal probe
> > deferral log for getting MSI domain.
> > This makes the kernel log clean and we do not get recurring logs
> > stating: "Failed to get MSI domain".
> 
> Or not print at all?

that would be better one :-)

> 
> Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> 
> > 
> > Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> > ---
> >   drivers/dma/ti/k3-udma.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> > index ce8b80bb34d7..e540166cf4c7 100644
> > --- a/drivers/dma/ti/k3-udma.c
> > +++ b/drivers/dma/ti/k3-udma.c
> > @@ -5344,7 +5344,7 @@ static int udma_probe(struct platform_device *pdev)
> >   	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
> >   					    DOMAIN_BUS_TI_SCI_INTA_MSI);
> >   	if (!dev->msi.domain) {
> > -		dev_err(dev, "Failed to get MSI domain\n");
> > +		dev_dbg(dev, "Failed to get MSI domain\n");
> >   		return -EPROBE_DEFER;
> >   	}
> 
> -- 
> Péter

-- 
~Vinod