[PATCH 3/3] arm64: dts: qcom: sm8250-lenovo-j716f: Enable ADSP/CDSP/SLPI

David Wronek posted 3 patches 2 years, 9 months ago
[PATCH 3/3] arm64: dts: qcom: sm8250-lenovo-j716f: Enable ADSP/CDSP/SLPI
Posted by David Wronek 2 years, 9 months ago
Enabled the ADSP, CDSP and SLPI remoteprocs with a simple "okay".
Firmware needs to be provided by the Linux distribution, as it's signed
and needs to come from stock Android.

Signed-off-by: David Wronek <davidwronek@gmail.com>
---
 arch/arm64/boot/dts/qcom/sm8250-lenovo-j716f.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-lenovo-j716f.dts b/arch/arm64/boot/dts/qcom/sm8250-lenovo-j716f.dts
index c493721ef664..33edeb6f3ef4 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-lenovo-j716f.dts
+++ b/arch/arm64/boot/dts/qcom/sm8250-lenovo-j716f.dts
@@ -76,6 +76,11 @@ vreg_s6c_0p88: smpc6-regulator {
 	};
 };
 
+&adsp {
+	status = "okay";
+	firmware-name = "qcom/sm8250/j716f/adsp.mbn";
+};
+
 &apps_rsc {
 	pm8150-rpmh-regulators {
 		compatible = "qcom,pm8150-rpmh-regulators";
@@ -434,6 +439,11 @@ vreg_l7f_1p8: ldo7 {
 	};
 };
 
+&cdsp {
+	status = "okay";
+	firmware-name = "qcom/sm8250/j716f/cdsp.mbn";
+};
+
 &gpi_dma0 {
 	status = "okay";
 };
@@ -515,6 +525,11 @@ &qupv3_id_2 {
 	status = "okay";
 };
 
+&slpi {
+	status = "okay";
+	firmware-name = "qcom/sm8250/j716f/slpi.mbn";
+};
+
 &tlmm {
 	gpio-reserved-ranges = <40 4>;
 };
-- 
2.38.1
Re: [PATCH 3/3] arm64: dts: qcom: sm8250-lenovo-j716f: Enable ADSP/CDSP/SLPI
Posted by Dmitry Baryshkov 2 years, 9 months ago

On 27 November 2022 20:08:58 GMT+03:00, David Wronek <davidwronek@gmail.com> wrote:
>Enabled the ADSP, CDSP and SLPI remoteprocs with a simple "okay".
>Firmware needs to be provided by the Linux distribution, as it's signed
>and needs to come from stock Android.
>
>Signed-off-by: David Wronek <davidwronek@gmail.com>
>---
> arch/arm64/boot/dts/qcom/sm8250-lenovo-j716f.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/qcom/sm8250-lenovo-j716f.dts b/arch/arm64/boot/dts/qcom/sm8250-lenovo-j716f.dts
>index c493721ef664..33edeb6f3ef4 100644
>--- a/arch/arm64/boot/dts/qcom/sm8250-lenovo-j716f.dts
>+++ b/arch/arm64/boot/dts/qcom/sm8250-lenovo-j716f.dts
>@@ -76,6 +76,11 @@ vreg_s6c_0p88: smpc6-regulator {
> 	};
> };
> 
>+&adsp {
>+	status = "okay";
>+	firmware-name = "qcom/sm8250/j716f/adsp.mbn";
>+};
>+
> &apps_rsc {
> 	pm8150-rpmh-regulators {
> 		compatible = "qcom,pm8150-rpmh-regulators";
>@@ -434,6 +439,11 @@ vreg_l7f_1p8: ldo7 {
> 	};
> };
> 
>+&cdsp {
>+	status = "okay";
>+	firmware-name = "qcom/sm8250/j716f/cdsp.mbn";

Please add vendor to the firmware path, see sc8280 x13s dts


>+};
>+
> &gpi_dma0 {
> 	status = "okay";
> };
>@@ -515,6 +525,11 @@ &qupv3_id_2 {
> 	status = "okay";
> };
> 
>+&slpi {
>+	status = "okay";
>+	firmware-name = "qcom/sm8250/j716f/slpi.mbn";
>+};
>+
> &tlmm {
> 	gpio-reserved-ranges = <40 4>;
> };

-- 
With best wishes
Dmitry
Re: [PATCH 3/3] arm64: dts: qcom: sm8250-lenovo-j716f: Enable ADSP/CDSP/SLPI
Posted by Krzysztof Kozlowski 2 years, 9 months ago
On 27/11/2022 18:08, David Wronek wrote:
> Enabled the ADSP, CDSP and SLPI remoteprocs with a simple "okay".

s/Enabled/Enable/

> Firmware needs to be provided by the Linux distribution, as it's signed
> and needs to come from stock Android.
> 
> Signed-off-by: David Wronek <davidwronek@gmail.com>
> ---

You just added the DTS, so this should be squashed with previous patch.
Why adding incomplete DTS just to fix it up/extend immediately?

Best regards,
Krzysztof