[v4] ARM: Make the dumped instructions are consistent with the disassembled ones

[PATCH v4 0/2] ARM: Make the dumped instructions are consistent with the disassembled ones

Posted by Zhen Lei 2 years, 9 months ago

v3 --> v4:
1. The sparse warnings that are not involved in the modification are
   not eliminated.
2. Eliminate the sparse warnings involved in the modification when
   refactor dump_instr(), no longer use a separate patch.

v2 --> v3:
1. Don't use '__force to' cleanup the sparse warnings
2. Refactor dump_instr()
3. Relace cpu_to_le{32|16}() with __mem_to_opcode_{arm|thumb16}()


v1 --> v2:
1. Cleanup sparse warnings.

Zhen Lei (2):
  ARM: Refactor dump_instr()
  ARM: Make the dumped instructions are consistent with the disassembled
    ones

 arch/arm/kernel/traps.c | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

-- 
2.25.1

Re: [PATCH v4 0/2] ARM: Make the dumped instructions are consistent with the disassembled ones

Posted by Russell King (Oracle) 2 years, 9 months ago

On Sat, Nov 26, 2022 at 08:21:35PM +0800, Zhen Lei wrote:
> v3 --> v4:
> 1. The sparse warnings that are not involved in the modification are
>    not eliminated.
> 2. Eliminate the sparse warnings involved in the modification when
>    refactor dump_instr(), no longer use a separate patch.
> 
> v2 --> v3:
> 1. Don't use '__force to' cleanup the sparse warnings
> 2. Refactor dump_instr()
> 3. Relace cpu_to_le{32|16}() with __mem_to_opcode_{arm|thumb16}()
> 
> 
> v1 --> v2:
> 1. Cleanup sparse warnings.
> 
> Zhen Lei (2):
>   ARM: Refactor dump_instr()
>   ARM: Make the dumped instructions are consistent with the disassembled
>     ones

Looks good now, thanks.

Please put it in my patch system, details in my signature. Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!