kernfs: remove an unused if statement in kernfs_path_from_node_locked()

[PATCH v2] kernfs: remove an unused if statement in kernfs_path_from_node_locked()

Posted by Zhen Lei 2 years, 9 months ago

It makes no sense to call kernfs_path_from_node_locked() with NULL buf,
and no one is doing that right now.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 fs/kernfs/dir.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
index f33b3baad07cb36..8a11bf189970274 100644
--- a/fs/kernfs/dir.c
+++ b/fs/kernfs/dir.c
@@ -149,9 +149,6 @@ static int kernfs_path_from_node_locked(struct kernfs_node *kn_to,
 	if (kn_from == kn_to)
 		return strlcpy(buf, "/", buflen);
 
-	if (!buf)
-		return -EINVAL;
-
 	common = kernfs_common_ancestor(kn_from, kn_to);
 	if (WARN_ON(!common))
 		return -EINVAL;
-- 
2.25.1

Re: [PATCH v2] kernfs: remove an unused if statement in kernfs_path_from_node_locked()

Posted by Tejun Heo 2 years, 9 months ago

On Sat, Nov 26, 2022 at 07:16:34PM +0800, Zhen Lei wrote:
> It makes no sense to call kernfs_path_from_node_locked() with NULL buf,
> and no one is doing that right now.
> 
> Suggested-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun