ALSA: asihpi: fix missing pci_disable_device()

[PATCH] ALSA: asihpi: fix missing pci_disable_device()

Posted by Liu Shixin 2 years, 9 months ago

pci_disable_device() need be called while module exiting, switch to use
pcim_enable(), pci_disable_device() will be called in pcim_release().

Fixes: 3285ea10e9b0 ("ALSA: asihpi - Interrelated HPI tidy up.")
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
 sound/pci/asihpi/hpioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/asihpi/hpioctl.c b/sound/pci/asihpi/hpioctl.c
index bb31b7fe867d..477a5b4b50bc 100644
--- a/sound/pci/asihpi/hpioctl.c
+++ b/sound/pci/asihpi/hpioctl.c
@@ -361,7 +361,7 @@ int asihpi_adapter_probe(struct pci_dev *pci_dev,
 		pci_dev->device, pci_dev->subsystem_vendor,
 		pci_dev->subsystem_device, pci_dev->devfn);
 
-	if (pci_enable_device(pci_dev) < 0) {
+	if (pcim_enable_device(pci_dev) < 0) {
 		dev_err(&pci_dev->dev,
 			"pci_enable_device failed, disabling device\n");
 		return -EIO;
-- 
2.25.1

Re: [PATCH] ALSA: asihpi: fix missing pci_disable_device()

Posted by Takashi Iwai 2 years, 9 months ago

On Sat, 26 Nov 2022 03:14:29 +0100,
Liu Shixin wrote:
> 
> pci_disable_device() need be called while module exiting, switch to use
> pcim_enable(), pci_disable_device() will be called in pcim_release().
> 
> Fixes: 3285ea10e9b0 ("ALSA: asihpi - Interrelated HPI tidy up.")
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>

Thanks, applied now.


Takashi