ARM: dts: sti: align LED node names with dtschema

[PATCH] ARM: dts: sti: align LED node names with dtschema

Posted by Krzysztof Kozlowski 2 years, 9 months ago

The node names should be generic and DT schema expects certain pattern:

  stih407-b2120.dtb: leds: 'green', 'red' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/stih410-b2260.dts  | 8 ++++----
 arch/arm/boot/dts/stih418-b2199.dts  | 4 ++--
 arch/arm/boot/dts/stih418-b2264.dts  | 2 +-
 arch/arm/boot/dts/stihxxx-b2120.dtsi | 4 ++--
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index 26d93f26f6d0..240b62040000 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -27,26 +27,26 @@ aliases {
 
 	leds {
 		compatible = "gpio-leds";
-		user_green_1 {
+		led-user-green-1 {
 			label = "User_green_1";
 			gpios = <&pio1 3 GPIO_ACTIVE_LOW>;
 			linux,default-trigger = "heartbeat";
 			default-state = "off";
 		};
 
-		user_green_2 {
+		led-user-green-2 {
 			label = "User_green_2";
 			gpios = <&pio4 1 GPIO_ACTIVE_LOW>;
 			default-state = "off";
 		};
 
-		user_green_3 {
+		led-user-green-3 {
 			label = "User_green_3";
 			gpios = <&pio2 1 GPIO_ACTIVE_LOW>;
 			default-state = "off";
 		};
 
-		user_green_4 {
+		led-user-green-4 {
 			label = "User_green_4";
 			gpios = <&pio2 5 GPIO_ACTIVE_LOW>;
 			default-state = "off";
diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
index d21bcc7c1271..53ac6c2b7b7d 100644
--- a/arch/arm/boot/dts/stih418-b2199.dts
+++ b/arch/arm/boot/dts/stih418-b2199.dts
@@ -26,12 +26,12 @@ aliases {
 
 	leds {
 		compatible = "gpio-leds";
-		red {
+		led-red {
 			label = "Front Panel LED";
 			gpios = <&pio4 1 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};
-		green {
+		led-green {
 			gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
 			default-state = "off";
 		};
diff --git a/arch/arm/boot/dts/stih418-b2264.dts b/arch/arm/boot/dts/stih418-b2264.dts
index a99604bebf8c..34a518b037ab 100644
--- a/arch/arm/boot/dts/stih418-b2264.dts
+++ b/arch/arm/boot/dts/stih418-b2264.dts
@@ -76,7 +76,7 @@ aliases {
 	soc {
 		leds {
 			compatible = "gpio-leds";
-			green {
+			led-green {
 				gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
 				default-state = "off";
 			};
diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
index 2aa94605d3d4..920a0bad7494 100644
--- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
+++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
@@ -9,12 +9,12 @@
 / {
 	leds {
 		compatible = "gpio-leds";
-		red {
+		led-red {
 			label = "Front Panel LED";
 			gpios = <&pio4 1 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};
-		green {
+		led-green {
 			gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
 			default-state = "off";
 		};
-- 
2.34.1

Re: [PATCH] ARM: dts: sti: align LED node names with dtschema

Posted by Krzysztof Kozlowski 2 years, 9 months ago

On Fri, 25 Nov 2022 15:41:16 +0100, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects certain pattern:
> 
>   stih407-b2120.dtb: leds: 'green', 'red' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
> 
> 

Applied, thanks!

[1/1] ARM: dts: sti: align LED node names with dtschema
      https://git.kernel.org/krzk/linux-dt/c/91bf30a42b16257f98345c9ba519d72babbbaf8a

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH] ARM: dts: sti: align LED node names with dtschema

Posted by Patrice CHOTARD 2 years, 9 months ago

Hi Krzysztof 

On 11/25/22 15:41, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects certain pattern:
> 
>   stih407-b2120.dtb: leds: 'green', 'red' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm/boot/dts/stih410-b2260.dts  | 8 ++++----
>  arch/arm/boot/dts/stih418-b2199.dts  | 4 ++--
>  arch/arm/boot/dts/stih418-b2264.dts  | 2 +-
>  arch/arm/boot/dts/stihxxx-b2120.dtsi | 4 ++--
>  4 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
> index 26d93f26f6d0..240b62040000 100644
> --- a/arch/arm/boot/dts/stih410-b2260.dts
> +++ b/arch/arm/boot/dts/stih410-b2260.dts
> @@ -27,26 +27,26 @@ aliases {
>  
>  	leds {
>  		compatible = "gpio-leds";
> -		user_green_1 {
> +		led-user-green-1 {
>  			label = "User_green_1";
>  			gpios = <&pio1 3 GPIO_ACTIVE_LOW>;
>  			linux,default-trigger = "heartbeat";
>  			default-state = "off";
>  		};
>  
> -		user_green_2 {
> +		led-user-green-2 {
>  			label = "User_green_2";
>  			gpios = <&pio4 1 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  
> -		user_green_3 {
> +		led-user-green-3 {
>  			label = "User_green_3";
>  			gpios = <&pio2 1 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  
> -		user_green_4 {
> +		led-user-green-4 {
>  			label = "User_green_4";
>  			gpios = <&pio2 5 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
> diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
> index d21bcc7c1271..53ac6c2b7b7d 100644
> --- a/arch/arm/boot/dts/stih418-b2199.dts
> +++ b/arch/arm/boot/dts/stih418-b2199.dts
> @@ -26,12 +26,12 @@ aliases {
>  
>  	leds {
>  		compatible = "gpio-leds";
> -		red {
> +		led-red {
>  			label = "Front Panel LED";
>  			gpios = <&pio4 1 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "heartbeat";
>  		};
> -		green {
> +		led-green {
>  			gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
>  			default-state = "off";
>  		};
> diff --git a/arch/arm/boot/dts/stih418-b2264.dts b/arch/arm/boot/dts/stih418-b2264.dts
> index a99604bebf8c..34a518b037ab 100644
> --- a/arch/arm/boot/dts/stih418-b2264.dts
> +++ b/arch/arm/boot/dts/stih418-b2264.dts
> @@ -76,7 +76,7 @@ aliases {
>  	soc {
>  		leds {
>  			compatible = "gpio-leds";
> -			green {
> +			led-green {
>  				gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
>  				default-state = "off";
>  			};
> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> index 2aa94605d3d4..920a0bad7494 100644
> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> @@ -9,12 +9,12 @@
>  / {
>  	leds {
>  		compatible = "gpio-leds";
> -		red {
> +		led-red {
>  			label = "Front Panel LED";
>  			gpios = <&pio4 1 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "heartbeat";
>  		};
> -		green {
> +		led-green {
>  			gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
>  			default-state = "off";
>  		};

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice