[PATCH] iio: addac: ad74413r: fix blank line after declaration warning

Cosmin Tanislav posted 1 patch 1 week, 3 days ago
drivers/iio/addac/ad74413r.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] iio: addac: ad74413r: fix blank line after declaration warning
Posted by Cosmin Tanislav 1 week, 3 days ago
Checkpatch wants a blank line after all declarations. Add it now,
even though the patch has already been submitted.

Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
Fixes: 7b2366008125 ("iio: addac: ad74413r: add spi_device_id table")
---
 drivers/iio/addac/ad74413r.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
index 61030053cbea..f32c8c2fb26d 100644
--- a/drivers/iio/addac/ad74413r.c
+++ b/drivers/iio/addac/ad74413r.c
@@ -1315,6 +1315,7 @@ static int ad74413r_probe(struct spi_device *spi)
 	st->chip_info = device_get_match_data(&spi->dev);
 	if (!st->chip_info) {
 		const struct spi_device_id *id = spi_get_device_id(spi);
+
 		if (id)
 			st->chip_info =
 				(struct ad74413r_chip_info *)id->driver_data;
-- 
2.38.1
Re: [PATCH] iio: addac: ad74413r: fix blank line after declaration warning
Posted by Jonathan Cameron 1 week, 2 days ago
On Thu, 24 Nov 2022 17:30:49 +0200
Cosmin Tanislav <demonsingur@gmail.com> wrote:

> Checkpatch wants a blank line after all declarations. Add it now,
> even though the patch has already been submitted.
> 
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
> Fixes: 7b2366008125 ("iio: addac: ad74413r: add spi_device_id table")
Dropped fixes tag as this is just cosmetic.

Applied.
> ---
>  drivers/iio/addac/ad74413r.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
> index 61030053cbea..f32c8c2fb26d 100644
> --- a/drivers/iio/addac/ad74413r.c
> +++ b/drivers/iio/addac/ad74413r.c
> @@ -1315,6 +1315,7 @@ static int ad74413r_probe(struct spi_device *spi)
>  	st->chip_info = device_get_match_data(&spi->dev);
>  	if (!st->chip_info) {
>  		const struct spi_device_id *id = spi_get_device_id(spi);
> +
>  		if (id)
>  			st->chip_info =
>  				(struct ad74413r_chip_info *)id->driver_data;