memory: renesas-rpc-if: Fix missing setting address

[PATCH] memory: renesas-rpc-if: Fix missing setting address

Posted by JaimeLiao 3 years, 4 months ago

In the RPC manual mode, if the data direction is not set
(such as the flash erase command), the address misses the
setting.

Signed-off-by: JaimeLiao <jaimeliao.tw@gmail.com>
---
 drivers/memory/renesas-rpc-if.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
index 4316988d791a..bdf0a7f68ff2 100644
--- a/drivers/memory/renesas-rpc-if.c
+++ b/drivers/memory/renesas-rpc-if.c
@@ -571,6 +571,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
 		}
 		break;
 	default:
+		regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
 		regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
 		regmap_write(rpc->regmap, RPCIF_SMCR,
 			     rpc->smcr | RPCIF_SMCR_SPIE);
-- 
2.17.1

Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address

Posted by Geert Uytterhoeven 3 years, 2 months ago

Hi Jaime,

CC linux-renesas-soc

Thanks for your patch!

On Wed, Nov 23, 2022 at 3:55 AM JaimeLiao <jaimeliao.tw@gmail.com> wrote:
> In the RPC manual mode, if the data direction is not set
> (such as the flash erase command), the address misses the
> setting.

This patch never received review comments.
As of commit fff53a551db50f5e ("memory: renesas-rpc-if: Correct QSPI
data transfer in Manual mode") in v5.16-rc1, RPCIF_SMADR is written
before the switch() statement, hence this patch can be ignored.

See also
https://lore.kernel.org/all/CAMuHMdWpvuC2Cm41jCQm+rT8MZB5GN+Z0bPz941QzsHX17Ux-g@mail.gmail.com

> Signed-off-by: JaimeLiao <jaimeliao.tw@gmail.com>

> --- a/drivers/memory/renesas-rpc-if.c
> +++ b/drivers/memory/renesas-rpc-if.c
> @@ -571,6 +571,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
>                 }
>                 break;
>         default:
> +               regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
>                 regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
>                 regmap_write(rpc->regmap, RPCIF_SMCR,
>                              rpc->smcr | RPCIF_SMCR_SPIE);

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address

Posted by Krzysztof Kozlowski 3 years, 3 months ago

On Wed, 23 Nov 2022 10:51:41 +0800, JaimeLiao wrote:
> In the RPC manual mode, if the data direction is not set
> (such as the flash erase command), the address misses the
> setting.
> 
> 

Applied, thanks!

[1/1] memory: renesas-rpc-if: Fix missing setting address
      https://git.kernel.org/krzk/linux-mem-ctrl/c/21a1234f82cbf4258445072bb23c38fed2ce6cb3

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address

Posted by Krzysztof Kozlowski 3 years, 2 months ago

On 27/12/2022 09:59, Krzysztof Kozlowski wrote:
> On Wed, 23 Nov 2022 10:51:41 +0800, JaimeLiao wrote:
>> In the RPC manual mode, if the data direction is not set
>> (such as the flash erase command), the address misses the
>> setting.
>>
>>
> 
> Applied, thanks!
> 
> [1/1] memory: renesas-rpc-if: Fix missing setting address
>       https://git.kernel.org/krzk/linux-mem-ctrl/c/21a1234f82cbf4258445072bb23c38fed2ce6cb3

And drop. Stop sending the same patch all over again...

Best regards,
Krzysztof