[PATCH v2 net-next 0/3] cleanup ocelot_stats exposure

Colin Foster posted 3 patches 3 years, 4 months ago
drivers/net/dsa/ocelot/felix.c             |   1 -
drivers/net/dsa/ocelot/felix.h             |   1 -
drivers/net/dsa/ocelot/felix_vsc9959.c     |   5 -
drivers/net/dsa/ocelot/seville_vsc9953.c   |   5 -
drivers/net/ethernet/mscc/ocelot_stats.c   | 244 ++++++++++++++++++++-
drivers/net/ethernet/mscc/ocelot_vsc7514.c |   5 -
include/soc/mscc/ocelot.h                  | 216 ------------------
7 files changed, 235 insertions(+), 242 deletions(-)
[PATCH v2 net-next 0/3] cleanup ocelot_stats exposure
Posted by Colin Foster 3 years, 4 months ago
The ocelot_stats structures became redundant across all users. Replace
this redundancy with a static const struct. After doing this, several
definitions inside include/soc/mscc/ocelot.h no longer needed to be
shared. Patch 2 removes them.

Checkpatch throws an error for a complicated macro not in parentheses. I
understand the reason for OCELOT_COMMON_STATS was to allow expansion, but
interestingly this patch set is essentially reverting the ability for
expansion. I'm keeping the macro in this set, but am open to remove it,
since it doesn't _actually_ provide any immediate benefits anymore.


v1->v2
    * Fix unused variable warning from v1 (patch 1)
    * Pick up forgotten stats patch (patch 3)

Colin Foster (3):
  net: mscc: ocelot: remove redundant stats_layout pointers
  net: mscc: ocelot: remove unnecessary exposure of stats structures
  net: mscc: ocelot: issue a warning if stats are incorrectly ordered

 drivers/net/dsa/ocelot/felix.c             |   1 -
 drivers/net/dsa/ocelot/felix.h             |   1 -
 drivers/net/dsa/ocelot/felix_vsc9959.c     |   5 -
 drivers/net/dsa/ocelot/seville_vsc9953.c   |   5 -
 drivers/net/ethernet/mscc/ocelot_stats.c   | 244 ++++++++++++++++++++-
 drivers/net/ethernet/mscc/ocelot_vsc7514.c |   5 -
 include/soc/mscc/ocelot.h                  | 216 ------------------
 7 files changed, 235 insertions(+), 242 deletions(-)

-- 
2.25.1
Re: [PATCH v2 net-next 0/3] cleanup ocelot_stats exposure
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 4 months ago
Hello:

This series was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Sat, 19 Nov 2022 15:14:03 -0800 you wrote:
> The ocelot_stats structures became redundant across all users. Replace
> this redundancy with a static const struct. After doing this, several
> definitions inside include/soc/mscc/ocelot.h no longer needed to be
> shared. Patch 2 removes them.
> 
> Checkpatch throws an error for a complicated macro not in parentheses. I
> understand the reason for OCELOT_COMMON_STATS was to allow expansion, but
> interestingly this patch set is essentially reverting the ability for
> expansion. I'm keeping the macro in this set, but am open to remove it,
> since it doesn't _actually_ provide any immediate benefits anymore.
> 
> [...]

Here is the summary with links:
  - [v2,net-next,1/3] net: mscc: ocelot: remove redundant stats_layout pointers
    https://git.kernel.org/netdev/net-next/c/33d5eeb9a684
  - [v2,net-next,2/3] net: mscc: ocelot: remove unnecessary exposure of stats structures
    https://git.kernel.org/netdev/net-next/c/a3bb8f521fd8
  - [v2,net-next,3/3] net: mscc: ocelot: issue a warning if stats are incorrectly ordered
    https://git.kernel.org/netdev/net-next/c/877e7b7c3b12

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html