[v5] cpuhp: fix some st->target issues

[PATCH v5 0/2] cpuhp: fix some st->target issues

Posted by Phil Auld 3 years, 4 months ago

Fix a few cpuhp related issues.

The first prevents target_store() from calling cpu_down() when
target == state which prevents the cpu being incorrectly marked
as dying.  The second just makes the boot cpu have a valid cpuhp
target rather than 0 (CPU_OFFLINE) while being in state
CPU_ONLINE.

v3: Added code to make sure st->target == target in the nop case.

v4: Use WARN_ON in the case where state == target but st->target does
not.

v5: Fixed lowercase on first patch title and cleaned up cover letter.
Rebased on v6.1-rc5.

Phil Auld (2):
  cpuhp: Make target_store() a nop when target == state
  cpuhp: Set cpuhp target for boot cpu

 cpu.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.31.1

Re: [PATCH v5 0/2] cpuhp: fix some st->target issues

Posted by Phil Auld 3 years, 4 months ago

On Thu, Nov 17, 2022 at 11:23:27AM -0500 Phil Auld wrote:
> Fix a few cpuhp related issues.
> 
> The first prevents target_store() from calling cpu_down() when
> target == state which prevents the cpu being incorrectly marked
> as dying.  The second just makes the boot cpu have a valid cpuhp
> target rather than 0 (CPU_OFFLINE) while being in state
> CPU_ONLINE.
> 
> v3: Added code to make sure st->target == target in the nop case.
> 
> v4: Use WARN_ON in the case where state == target but st->target does
> not.
> 
> v5: Fixed lowercase on first patch title and cleaned up cover letter.
> Rebased on v6.1-rc5.
> 
> Phil Auld (2):
>   cpuhp: Make target_store() a nop when target == state
>   cpuhp: Set cpuhp target for boot cpu
> 
>  cpu.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>

Thanks for picking these up, Thomas!


Cheers,
Phil


> -- 
> 2.31.1
> 

--