1. Patchew
  2. linux
  3. View series

[PATCH] dt-bindings: cpufreq: cpufreq-qcom-hw: Add SM8550 compatible

Abel Vesa posted 1 patch 3 years, 4 months ago
There is a newer version of this series
.../devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml       | 7 +++++++
1 file changed, 7 insertions(+)
[PATCH] dt-bindings: cpufreq: cpufreq-qcom-hw: Add SM8550 compatible
Posted by Abel Vesa 3 years, 4 months ago 
Add compatible for EPSS CPUFREQ-HW on SM8550.
Also document the interrupts.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 .../devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml       | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
index e58c55f78aaa..83d814afc780 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
@@ -27,6 +27,7 @@ properties:
           - enum:
               - qcom,sm6375-cpufreq-epss
               - qcom,sm8250-cpufreq-epss
+              - qcom,sm8550-cpufreq-epss
           - const: qcom,cpufreq-epss
 
   reg:
@@ -53,6 +54,12 @@ properties:
       - const: xo
       - const: alternate
 
+  interrupts:
+    maxItems: 3
+
+  interrupt-names:
+    maxItems: 3
+
   '#freq-domain-cells':
     const: 1
 
-- 
2.34.1
Re: [PATCH] dt-bindings: cpufreq: cpufreq-qcom-hw: Add SM8550 compatible
Posted by Rob Herring 3 years, 4 months ago 
On Wed, 16 Nov 2022 13:50:46 +0200, Abel Vesa wrote:
> Add compatible for EPSS CPUFREQ-HW on SM8550.
> Also document the interrupts.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  .../devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml       | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/


cpufreq@17d43000: interrupts-extended: [[215, 0], [216, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dtb
	arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dtb
	arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-apollo.dtb

cpufreq@17d43000: interrupts-extended: [[221, 0], [222, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm845-lg-judyp.dtb

cpufreq@17d43000: interrupts-extended: [[223, 0], [224, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dtb

cpufreq@17d43000: interrupts-extended: [[226, 0], [227, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dtb

cpufreq@17d43000: interrupts-extended: [[227, 0], [228, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm845-mtp.dtb

cpufreq@17d43000: interrupts-extended: [[228, 0], [229, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb
	arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dtb

cpufreq@17d43000: interrupts-extended: [[229, 0], [230, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dtb

cpufreq@17d43000: interrupts-extended: [[230, 0], [231, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dtb

cpufreq@17d43000: interrupts-extended: [[231, 0], [232, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dtb

cpufreq@17d43000: interrupts-extended: [[234, 0], [235, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dtb
	arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dtb
	arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dtb

cpufreq@17d43000: interrupts-extended: [[235, 0], [236, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dtb

cpufreq@17d43000: interrupts-extended: [[256, 0], [257, 0]] is too short
	arch/arm64/boot/dts/qcom/sdm845-db845c.dtb

cpufreq@17d91000: compatible: 'oneOf' conditional failed, one must be fixed:
	arch/arm64/boot/dts/qcom/sm8450-hdk.dtb
	arch/arm64/boot/dts/qcom/sm8450-qrd.dtb
	arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dtb

cpufreq@18591000: compatible: 'oneOf' conditional failed, one must be fixed:
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dtb
	arch/arm64/boot/dts/qcom/sc7280-idp2.dtb
	arch/arm64/boot/dts/qcom/sc7280-idp.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
	arch/arm64/boot/dts/qcom/sm8350-hdk.dtb
	arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dtb
	arch/arm64/boot/dts/qcom/sm8350-mtp.dtb
	arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dtb
	arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dtb
Re: [PATCH] dt-bindings: cpufreq: cpufreq-qcom-hw: Add SM8550 compatible
Posted by Krzysztof Kozlowski 3 years, 4 months ago 
On 16/11/2022 12:50, Abel Vesa wrote:
> Add compatible for EPSS CPUFREQ-HW on SM8550.
> Also document the interrupts.

None of other variants had interrupts so far, so you are adding it for
new SoC, right? Or documenting existing usage? If the first, you need
allOf:if:then.

> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  .../devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml       | 7 +++++++
>  1 file changed, 7 insertions(+)
> 


Best regards,
Krzysztof

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.