1. Patchew
  2. linux
  3. [PATCH 00/10] Add base device tree files for SM8550
  4. View patch

[PATCH 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi

Abel Vesa posted 10 patches 3 years, 4 months ago
[PATCH 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi
Posted by Abel Vesa 3 years, 4 months ago 
From: Neil Armstrong <neil.armstrong@linaro.org>

Add nodes for pm8010 in separate dtsi file.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/qcom/pm8010.dtsi | 84 ++++++++++++++++++++++++++++
 1 file changed, 84 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pm8010.dtsi

diff --git a/arch/arm64/boot/dts/qcom/pm8010.dtsi b/arch/arm64/boot/dts/qcom/pm8010.dtsi
new file mode 100644
index 000000000000..0ea641e12209
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pm8010.dtsi
@@ -0,0 +1,84 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2022, Linaro Limited
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+/ {
+	thermal-zones {
+		pm8010-m-thermal {
+			polling-delay-passive = <100>;
+			polling-delay = <0>;
+
+			thermal-sensors = <&pm8010_m_temp_alarm>;
+
+			trips {
+				trip0 {
+					temperature = <95000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+
+				trip1 {
+					temperature = <115000>;
+					hysteresis = <0>;
+					type = "hot";
+				};
+			};
+		};
+
+		pm8010-n-thermal {
+			polling-delay-passive = <100>;
+			polling-delay = <0>;
+
+			thermal-sensors = <&pm8010_n_temp_alarm>;
+
+			trips {
+				trip0 {
+					temperature = <95000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+
+				trip1 {
+					temperature = <115000>;
+					hysteresis = <0>;
+					type = "hot";
+				};
+			};
+		};
+	};
+};
+
+
+&spmi_bus {
+	pm8010_m: pmic@c {
+		compatible = "qcom,pm8010", "qcom,spmi-pmic";
+		reg = <0xc SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		pm8010_m_temp_alarm: temp-alarm@2400 {
+			compatible = "qcom,spmi-temp-alarm";
+			reg = <0x2400>;
+			interrupts = <0xc 0x24 0x0 IRQ_TYPE_EDGE_BOTH>;
+			#thermal-sensor-cells = <0>;
+		};
+	};
+
+	pm8010_n: pmic@d {
+		compatible = "qcom,pm8010", "qcom,spmi-pmic";
+		reg = <0xd SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		pm8010_n_temp_alarm: temp-alarm@2400 {
+			compatible = "qcom,spmi-temp-alarm";
+			reg = <0x2400>;
+			interrupts = <0xd 0x24 0x0 IRQ_TYPE_EDGE_BOTH>;
+			#thermal-sensor-cells = <0>;
+		};
+	};
+};
-- 
2.34.1
Re: [PATCH 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi
Posted by Krzysztof Kozlowski 3 years, 4 months ago 
On 16/11/2022 11:31, Abel Vesa wrote:
> From: Neil Armstrong <neil.armstrong@linaro.org>
> 
> Add nodes for pm8010 in separate dtsi file.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/pm8010.dtsi | 84 ++++++++++++++++++++++++++++
>  1 file changed, 84 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/pm8010.dtsi
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8010.dtsi b/arch/arm64/boot/dts/qcom/pm8010.dtsi
> new file mode 100644
> index 000000000000..0ea641e12209
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm8010.dtsi
> @@ -0,0 +1,84 @@
> +// SPDX-License-Identifier: BSD-3-Clause

Any reason why this is licensed BSD-3 clause? It's not a recommended
license (2 clause is). Same for other patches.

> +/*
> + * Copyright (c) 2022, Linaro Limited
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +/ {
> +	thermal-zones {
> +		pm8010-m-thermal {
> +			polling-delay-passive = <100>;
> +			polling-delay = <0>;
> +
> +			thermal-sensors = <&pm8010_m_temp_alarm>;
> +
> +			trips {
> +				trip0 {
> +					temperature = <95000>;
> +					hysteresis = <0>;
> +					type = "passive";
> +				};
> +
> +				trip1 {
> +					temperature = <115000>;
> +					hysteresis = <0>;
> +					type = "hot";
> +				};
> +			};
> +		};
> +
> +		pm8010-n-thermal {
> +			polling-delay-passive = <100>;
> +			polling-delay = <0>;
> +
> +			thermal-sensors = <&pm8010_n_temp_alarm>;
> +
> +			trips {
> +				trip0 {
> +					temperature = <95000>;
> +					hysteresis = <0>;
> +					type = "passive";
> +				};
> +
> +				trip1 {
> +					temperature = <115000>;
> +					hysteresis = <0>;
> +					type = "hot";
> +				};
> +			};
> +		};
> +	};
> +};
> +
> +

Just one blank line.


Best regards,
Krzysztof
Re: [PATCH 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi
Posted by Neil Armstrong 3 years, 4 months ago 
On 17/11/2022 13:51, Krzysztof Kozlowski wrote:
> On 16/11/2022 11:31, Abel Vesa wrote:
>> From: Neil Armstrong <neil.armstrong@linaro.org>
>>
>> Add nodes for pm8010 in separate dtsi file.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/pm8010.dtsi | 84 ++++++++++++++++++++++++++++
>>   1 file changed, 84 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/pm8010.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8010.dtsi b/arch/arm64/boot/dts/qcom/pm8010.dtsi
>> new file mode 100644
>> index 000000000000..0ea641e12209
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/pm8010.dtsi
>> @@ -0,0 +1,84 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
> 
> Any reason why this is licensed BSD-3 clause? It's not a recommended
> license (2 clause is). Same for other patches.

Probably a bad copy-paste from other existing files.

While checking, the majority of arch/arm64/boot/dts/qcom/pm*.dtsi uses BSD-3-Clause
so it seems this was done for quite a while now.

> 
>> +/*
>> + * Copyright (c) 2022, Linaro Limited
>> + */
>> +
>> +#include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/spmi/spmi.h>
>> +
>> +/ {
>> +	thermal-zones {
>> +		pm8010-m-thermal {
>> +			polling-delay-passive = <100>;
>> +			polling-delay = <0>;
>> +
>> +			thermal-sensors = <&pm8010_m_temp_alarm>;
>> +
>> +			trips {
>> +				trip0 {
>> +					temperature = <95000>;
>> +					hysteresis = <0>;
>> +					type = "passive";
>> +				};
>> +
>> +				trip1 {
>> +					temperature = <115000>;
>> +					hysteresis = <0>;
>> +					type = "hot";
>> +				};
>> +			};
>> +		};
>> +
>> +		pm8010-n-thermal {
>> +			polling-delay-passive = <100>;
>> +			polling-delay = <0>;
>> +
>> +			thermal-sensors = <&pm8010_n_temp_alarm>;
>> +
>> +			trips {
>> +				trip0 {
>> +					temperature = <95000>;
>> +					hysteresis = <0>;
>> +					type = "passive";
>> +				};
>> +
>> +				trip1 {
>> +					temperature = <115000>;
>> +					hysteresis = <0>;
>> +					type = "hot";
>> +				};
>> +			};
>> +		};
>> +	};
>> +};
>> +
>> +
> 
> Just one blank line.
> 
> 
> Best regards,
> Krzysztof
>
Re: [PATCH 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi
Posted by Krzysztof Kozlowski 3 years, 4 months ago 
On 18/11/2022 15:58, Neil Armstrong wrote:
> On 17/11/2022 13:51, Krzysztof Kozlowski wrote:
>> On 16/11/2022 11:31, Abel Vesa wrote:
>>> From: Neil Armstrong <neil.armstrong@linaro.org>
>>>
>>> Add nodes for pm8010 in separate dtsi file.
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> ---
>>>   arch/arm64/boot/dts/qcom/pm8010.dtsi | 84 ++++++++++++++++++++++++++++
>>>   1 file changed, 84 insertions(+)
>>>   create mode 100644 arch/arm64/boot/dts/qcom/pm8010.dtsi
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/pm8010.dtsi b/arch/arm64/boot/dts/qcom/pm8010.dtsi
>>> new file mode 100644
>>> index 000000000000..0ea641e12209
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/pm8010.dtsi
>>> @@ -0,0 +1,84 @@
>>> +// SPDX-License-Identifier: BSD-3-Clause
>>
>> Any reason why this is licensed BSD-3 clause? It's not a recommended
>> license (2 clause is). Same for other patches.
> 
> Probably a bad copy-paste from other existing files.
> 
> While checking, the majority of arch/arm64/boot/dts/qcom/pm*.dtsi uses BSD-3-Clause
> so it seems this was done for quite a while now.

If it is derivative work (of upstrea, downstream), then you might have
to keep BSD-3. But if not, how about changing it to BSD-2?

Best regards,
Krzysztof
Re: [PATCH 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi
Posted by neil.armstrong@linaro.org 3 years, 4 months ago 
On 18/11/2022 15:59, Krzysztof Kozlowski wrote:
> On 18/11/2022 15:58, Neil Armstrong wrote:
>> On 17/11/2022 13:51, Krzysztof Kozlowski wrote:
>>> On 16/11/2022 11:31, Abel Vesa wrote:
>>>> From: Neil Armstrong <neil.armstrong@linaro.org>
>>>>
>>>> Add nodes for pm8010 in separate dtsi file.
>>>>
>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/pm8010.dtsi | 84 ++++++++++++++++++++++++++++
>>>>    1 file changed, 84 insertions(+)
>>>>    create mode 100644 arch/arm64/boot/dts/qcom/pm8010.dtsi
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/pm8010.dtsi b/arch/arm64/boot/dts/qcom/pm8010.dtsi
>>>> new file mode 100644
>>>> index 000000000000..0ea641e12209
>>>> --- /dev/null
>>>> +++ b/arch/arm64/boot/dts/qcom/pm8010.dtsi
>>>> @@ -0,0 +1,84 @@
>>>> +// SPDX-License-Identifier: BSD-3-Clause
>>>
>>> Any reason why this is licensed BSD-3 clause? It's not a recommended
>>> license (2 clause is). Same for other patches.
>>
>> Probably a bad copy-paste from other existing files.
>>
>> While checking, the majority of arch/arm64/boot/dts/qcom/pm*.dtsi uses BSD-3-Clause
>> so it seems this was done for quite a while now.
> 
> If it is derivative work (of upstrea, downstream), then you might have
> to keep BSD-3. But if not, how about changing it to BSD-2?

It's definitely a derivative work from upstream pm*.dtsi files with BSD-3-Clause
licence.

Neil

> 
> Best regards,
> Krzysztof
>
Re: [PATCH 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi
Posted by Krzysztof Kozlowski 3 years, 4 months ago 
On 21/11/2022 14:29, neil.armstrong@linaro.org wrote:
>>>> Any reason why this is licensed BSD-3 clause? It's not a recommended
>>>> license (2 clause is). Same for other patches.
>>>
>>> Probably a bad copy-paste from other existing files.
>>>
>>> While checking, the majority of arch/arm64/boot/dts/qcom/pm*.dtsi uses BSD-3-Clause
>>> so it seems this was done for quite a while now.
>>
>> If it is derivative work (of upstrea, downstream), then you might have
>> to keep BSD-3. But if not, how about changing it to BSD-2?
> 
> It's definitely a derivative work from upstream pm*.dtsi files with BSD-3-Clause
> licence.

OK.

Best regards,
Krzysztof
Re: [PATCH 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi
Posted by Konrad Dybcio 3 years, 4 months ago 

On 16/11/2022 11:31, Abel Vesa wrote:
> From: Neil Armstrong <neil.armstrong@linaro.org>
> 
> Add nodes for pm8010 in separate dtsi file.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>   arch/arm64/boot/dts/qcom/pm8010.dtsi | 84 ++++++++++++++++++++++++++++
>   1 file changed, 84 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/qcom/pm8010.dtsi
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8010.dtsi b/arch/arm64/boot/dts/qcom/pm8010.dtsi
> new file mode 100644
> index 000000000000..0ea641e12209
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm8010.dtsi
> @@ -0,0 +1,84 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2022, Linaro Limited
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +/ {
> +	thermal-zones {
> +		pm8010-m-thermal {
> +			polling-delay-passive = <100>;
> +			polling-delay = <0>;
> +
> +			thermal-sensors = <&pm8010_m_temp_alarm>;
> +
> +			trips {
> +				trip0 {
> +					temperature = <95000>;
> +					hysteresis = <0>;
> +					type = "passive";
> +				};
> +
> +				trip1 {
> +					temperature = <115000>;
> +					hysteresis = <0>;
> +					type = "hot";
> +				};
> +			};
> +		};
> +
> +		pm8010-n-thermal {
> +			polling-delay-passive = <100>;
> +			polling-delay = <0>;
> +
> +			thermal-sensors = <&pm8010_n_temp_alarm>;
> +
> +			trips {
> +				trip0 {
> +					temperature = <95000>;
> +					hysteresis = <0>;
> +					type = "passive";
> +				};
> +
> +				trip1 {
> +					temperature = <115000>;
> +					hysteresis = <0>;
> +					type = "hot";
> +				};
> +			};
> +		};
> +	};
> +};
> +
> +
> +&spmi_bus {
> +	pm8010_m: pmic@c {
> +		compatible = "qcom,pm8010", "qcom,spmi-pmic";
> +		reg = <0xc SPMI_USID>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		pm8010_m_temp_alarm: temp-alarm@2400 {
> +			compatible = "qcom,spmi-temp-alarm";
> +			reg = <0x2400>;
> +			interrupts = <0xc 0x24 0x0 IRQ_TYPE_EDGE_BOTH>;
> +			#thermal-sensor-cells = <0>;
> +		};
> +	};
> +
> +	pm8010_n: pmic@d {
> +		compatible = "qcom,pm8010", "qcom,spmi-pmic";
> +		reg = <0xd SPMI_USID>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		pm8010_n_temp_alarm: temp-alarm@2400 {
> +			compatible = "qcom,spmi-temp-alarm";
> +			reg = <0x2400>;
> +			interrupts = <0xd 0x24 0x0 IRQ_TYPE_EDGE_BOTH>;
> +			#thermal-sensor-cells = <0>;
> +		};
> +	};
> +};

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.