[v2] vdpa/mlx5: Add debugfs subtree and fixes

[PATH v2 0/8] vdpa/mlx5: Add debugfs subtree and fixes

Posted by Eli Cohen 3 years, 4 months ago

This series is a resend of previously sent patch list. It adds a few
fixes so I treat as a v0 of a new series.

It adds a kernel config param CONFIG_MLX5_VDPA_STEERING_DEBUG that when
eabled allows to read rx unicast and multicast counters per tagged or untagged traffic.

Examples:
$ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-0/rx/untagged/mcast/packets
$ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-0/rx/untagged/ucast/bytes

v1->v2:
1. Reorder patches so fixes are first
2. Break "Fix rule forwarding VLAN to TIR" into two patches
3. Squash fix for bug in first patch from "Add RX counters to debugfs"
4. Move clearing of nb_registered before calling mlx5_notifier_unregister() in mlx5_vdpa_dev_del()


Eli Cohen (8):
  vdpa/mlx5: Fix rule forwarding VLAN to TIR
  vdpa/mlx5: Return error on vlan ctrl commands if not supported
  vdpa/mlx5: Fix wrong mac address deletion
  vdpa/mlx5: Avoid using reslock in event_handler
  vdpa/mlx5: Avoid overwriting CVQ iotlb
  vdpa/mlx5: Move some definitions to a new header file
  vdpa/mlx5: Add debugfs subtree
  vdpa/mlx5: Add RX counters to debugfs

 drivers/vdpa/Kconfig               |  12 ++
 drivers/vdpa/mlx5/Makefile         |   2 +-
 drivers/vdpa/mlx5/core/mlx5_vdpa.h |   5 +-
 drivers/vdpa/mlx5/core/mr.c        |  44 ++---
 drivers/vdpa/mlx5/net/debug.c      | 152 ++++++++++++++++++
 drivers/vdpa/mlx5/net/mlx5_vnet.c  | 250 ++++++++++++++---------------
 drivers/vdpa/mlx5/net/mlx5_vnet.h  |  94 +++++++++++
 7 files changed, 412 insertions(+), 147 deletions(-)
 create mode 100644 drivers/vdpa/mlx5/net/debug.c
 create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h

-- 
2.38.1

RE: [PATH v2 0/8] vdpa/mlx5: Add debugfs subtree and fixes

Posted by Eli Cohen 3 years, 4 months ago

Hi Michael,

Are you going to pull this series? It has been reviewed.


> -----Original Message-----
> From: Eli Cohen <elic@nvidia.com>
> Sent: Monday, 14 November 2022 15:18
> To: mst@redhat.com; jasowang@redhat.com; linux-kernel@vger.kernel.org;
> virtualization@lists.linux-foundation.org
> Cc: si-wei.liu@oracle.com; eperezma@redhat.com; lulu@redhat.com; Eli
> Cohen <elic@nvidia.com>
> Subject: [PATH v2 0/8] vdpa/mlx5: Add debugfs subtree and fixes
> 
> This series is a resend of previously sent patch list. It adds a few
> fixes so I treat as a v0 of a new series.
> 
> It adds a kernel config param CONFIG_MLX5_VDPA_STEERING_DEBUG that
> when
> eabled allows to read rx unicast and multicast counters per tagged or untagged
> traffic.
> 
> Examples:
> $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-
> 0/rx/untagged/mcast/packets
> $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-0/rx/untagged/ucast/bytes
> 
> v1->v2:
> 1. Reorder patches so fixes are first
> 2. Break "Fix rule forwarding VLAN to TIR" into two patches
> 3. Squash fix for bug in first patch from "Add RX counters to debugfs"
> 4. Move clearing of nb_registered before calling mlx5_notifier_unregister() in
> mlx5_vdpa_dev_del()
> 
> 
> Eli Cohen (8):
>   vdpa/mlx5: Fix rule forwarding VLAN to TIR
>   vdpa/mlx5: Return error on vlan ctrl commands if not supported
>   vdpa/mlx5: Fix wrong mac address deletion
>   vdpa/mlx5: Avoid using reslock in event_handler
>   vdpa/mlx5: Avoid overwriting CVQ iotlb
>   vdpa/mlx5: Move some definitions to a new header file
>   vdpa/mlx5: Add debugfs subtree
>   vdpa/mlx5: Add RX counters to debugfs
> 
>  drivers/vdpa/Kconfig               |  12 ++
>  drivers/vdpa/mlx5/Makefile         |   2 +-
>  drivers/vdpa/mlx5/core/mlx5_vdpa.h |   5 +-
>  drivers/vdpa/mlx5/core/mr.c        |  44 ++---
>  drivers/vdpa/mlx5/net/debug.c      | 152 ++++++++++++++++++
>  drivers/vdpa/mlx5/net/mlx5_vnet.c  | 250 ++++++++++++++---------------
>  drivers/vdpa/mlx5/net/mlx5_vnet.h  |  94 +++++++++++
>  7 files changed, 412 insertions(+), 147 deletions(-)
>  create mode 100644 drivers/vdpa/mlx5/net/debug.c
>  create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
> 
> --
> 2.38.1

RE: [PATH v2 0/8] vdpa/mlx5: Add debugfs subtree and fixes

Posted by Eli Cohen 3 years, 3 months ago

Michael?

> -----Original Message-----
> From: Eli Cohen
> Sent: Thursday, 24 November 2022 8:34
> To: mst@redhat.com; jasowang@redhat.com; linux-kernel@vger.kernel.org;
> virtualization@lists.linux-foundation.org
> Cc: si-wei.liu@oracle.com; eperezma@redhat.com; lulu@redhat.com
> Subject: RE: [PATH v2 0/8] vdpa/mlx5: Add debugfs subtree and fixes
> 
> Hi Michael,
> 
> Are you going to pull this series? It has been reviewed.
> 
> 
> > -----Original Message-----
> > From: Eli Cohen <elic@nvidia.com>
> > Sent: Monday, 14 November 2022 15:18
> > To: mst@redhat.com; jasowang@redhat.com; linux-
> kernel@vger.kernel.org;
> > virtualization@lists.linux-foundation.org
> > Cc: si-wei.liu@oracle.com; eperezma@redhat.com; lulu@redhat.com; Eli
> > Cohen <elic@nvidia.com>
> > Subject: [PATH v2 0/8] vdpa/mlx5: Add debugfs subtree and fixes
> >
> > This series is a resend of previously sent patch list. It adds a few
> > fixes so I treat as a v0 of a new series.
> >
> > It adds a kernel config param CONFIG_MLX5_VDPA_STEERING_DEBUG
> that
> > when
> > eabled allows to read rx unicast and multicast counters per tagged or
> untagged
> > traffic.
> >
> > Examples:
> > $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-
> > 0/rx/untagged/mcast/packets
> > $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-
> 0/rx/untagged/ucast/bytes
> >
> > v1->v2:
> > 1. Reorder patches so fixes are first
> > 2. Break "Fix rule forwarding VLAN to TIR" into two patches
> > 3. Squash fix for bug in first patch from "Add RX counters to debugfs"
> > 4. Move clearing of nb_registered before calling mlx5_notifier_unregister()
> in
> > mlx5_vdpa_dev_del()
> >
> >
> > Eli Cohen (8):
> >   vdpa/mlx5: Fix rule forwarding VLAN to TIR
> >   vdpa/mlx5: Return error on vlan ctrl commands if not supported
> >   vdpa/mlx5: Fix wrong mac address deletion
> >   vdpa/mlx5: Avoid using reslock in event_handler
> >   vdpa/mlx5: Avoid overwriting CVQ iotlb
> >   vdpa/mlx5: Move some definitions to a new header file
> >   vdpa/mlx5: Add debugfs subtree
> >   vdpa/mlx5: Add RX counters to debugfs
> >
> >  drivers/vdpa/Kconfig               |  12 ++
> >  drivers/vdpa/mlx5/Makefile         |   2 +-
> >  drivers/vdpa/mlx5/core/mlx5_vdpa.h |   5 +-
> >  drivers/vdpa/mlx5/core/mr.c        |  44 ++---
> >  drivers/vdpa/mlx5/net/debug.c      | 152 ++++++++++++++++++
> >  drivers/vdpa/mlx5/net/mlx5_vnet.c  | 250 ++++++++++++++---------------
> >  drivers/vdpa/mlx5/net/mlx5_vnet.h  |  94 +++++++++++
> >  7 files changed, 412 insertions(+), 147 deletions(-)
> >  create mode 100644 drivers/vdpa/mlx5/net/debug.c
> >  create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
> >
> > --
> > 2.38.1

Re: [PATH v2 0/8] vdpa/mlx5: Add debugfs subtree and fixes

Posted by Michael S. Tsirkin 3 years, 3 months ago

Yes it's all going into the next pull, thanks!

On Tue, Dec 13, 2022 at 07:33:08AM +0000, Eli Cohen wrote:
> Michael?
> 
> > -----Original Message-----
> > From: Eli Cohen
> > Sent: Thursday, 24 November 2022 8:34
> > To: mst@redhat.com; jasowang@redhat.com; linux-kernel@vger.kernel.org;
> > virtualization@lists.linux-foundation.org
> > Cc: si-wei.liu@oracle.com; eperezma@redhat.com; lulu@redhat.com
> > Subject: RE: [PATH v2 0/8] vdpa/mlx5: Add debugfs subtree and fixes
> > 
> > Hi Michael,
> > 
> > Are you going to pull this series? It has been reviewed.
> > 
> > 
> > > -----Original Message-----
> > > From: Eli Cohen <elic@nvidia.com>
> > > Sent: Monday, 14 November 2022 15:18
> > > To: mst@redhat.com; jasowang@redhat.com; linux-
> > kernel@vger.kernel.org;
> > > virtualization@lists.linux-foundation.org
> > > Cc: si-wei.liu@oracle.com; eperezma@redhat.com; lulu@redhat.com; Eli
> > > Cohen <elic@nvidia.com>
> > > Subject: [PATH v2 0/8] vdpa/mlx5: Add debugfs subtree and fixes
> > >
> > > This series is a resend of previously sent patch list. It adds a few
> > > fixes so I treat as a v0 of a new series.
> > >
> > > It adds a kernel config param CONFIG_MLX5_VDPA_STEERING_DEBUG
> > that
> > > when
> > > eabled allows to read rx unicast and multicast counters per tagged or
> > untagged
> > > traffic.
> > >
> > > Examples:
> > > $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-
> > > 0/rx/untagged/mcast/packets
> > > $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-
> > 0/rx/untagged/ucast/bytes
> > >
> > > v1->v2:
> > > 1. Reorder patches so fixes are first
> > > 2. Break "Fix rule forwarding VLAN to TIR" into two patches
> > > 3. Squash fix for bug in first patch from "Add RX counters to debugfs"
> > > 4. Move clearing of nb_registered before calling mlx5_notifier_unregister()
> > in
> > > mlx5_vdpa_dev_del()
> > >
> > >
> > > Eli Cohen (8):
> > >   vdpa/mlx5: Fix rule forwarding VLAN to TIR
> > >   vdpa/mlx5: Return error on vlan ctrl commands if not supported
> > >   vdpa/mlx5: Fix wrong mac address deletion
> > >   vdpa/mlx5: Avoid using reslock in event_handler
> > >   vdpa/mlx5: Avoid overwriting CVQ iotlb
> > >   vdpa/mlx5: Move some definitions to a new header file
> > >   vdpa/mlx5: Add debugfs subtree
> > >   vdpa/mlx5: Add RX counters to debugfs
> > >
> > >  drivers/vdpa/Kconfig               |  12 ++
> > >  drivers/vdpa/mlx5/Makefile         |   2 +-
> > >  drivers/vdpa/mlx5/core/mlx5_vdpa.h |   5 +-
> > >  drivers/vdpa/mlx5/core/mr.c        |  44 ++---
> > >  drivers/vdpa/mlx5/net/debug.c      | 152 ++++++++++++++++++
> > >  drivers/vdpa/mlx5/net/mlx5_vnet.c  | 250 ++++++++++++++---------------
> > >  drivers/vdpa/mlx5/net/mlx5_vnet.h  |  94 +++++++++++
> > >  7 files changed, 412 insertions(+), 147 deletions(-)
> > >  create mode 100644 drivers/vdpa/mlx5/net/debug.c
> > >  create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
> > >
> > > --
> > > 2.38.1
>