[v1] extcon: max77843: Replace irqchip mask_invert with unmask_base

[PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base

Posted by Aidan MacDonald 3 years, 5 months ago

Remove use of the deprecated mask_invert flag. Inverted mask
registers (where a '1' bit enables an IRQ) can be described more
directly as an unmask register.

Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
---
 drivers/extcon/extcon-max77843.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
index 8e6e97ec65a8..1bc0426ce3f1 100644
--- a/drivers/extcon/extcon-max77843.c
+++ b/drivers/extcon/extcon-max77843.c
@@ -189,8 +189,7 @@ static const struct regmap_irq max77843_muic_irq[] = {
 static const struct regmap_irq_chip max77843_muic_irq_chip = {
 	.name           = "max77843-muic",
 	.status_base    = MAX77843_MUIC_REG_INT1,
-	.mask_base      = MAX77843_MUIC_REG_INTMASK1,
-	.mask_invert    = true,
+	.unmask_base    = MAX77843_MUIC_REG_INTMASK1,
 	.num_regs       = 3,
 	.irqs           = max77843_muic_irq,
 	.num_irqs       = ARRAY_SIZE(max77843_muic_irq),
-- 
2.38.1

Re: [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base

Posted by Chanwoo Choi 3 years, 4 months ago

On 22. 11. 13. 00:24, Aidan MacDonald wrote:
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
> 
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
>  drivers/extcon/extcon-max77843.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index 8e6e97ec65a8..1bc0426ce3f1 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -189,8 +189,7 @@ static const struct regmap_irq max77843_muic_irq[] = {
>  static const struct regmap_irq_chip max77843_muic_irq_chip = {
>  	.name           = "max77843-muic",
>  	.status_base    = MAX77843_MUIC_REG_INT1,
> -	.mask_base      = MAX77843_MUIC_REG_INTMASK1,
> -	.mask_invert    = true,
> +	.unmask_base    = MAX77843_MUIC_REG_INTMASK1,
>  	.num_regs       = 3,
>  	.irqs           = max77843_muic_irq,
>  	.num_irqs       = ARRAY_SIZE(max77843_muic_irq),

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi

Re: [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base

Posted by Krzysztof Kozlowski 3 years, 5 months ago

On 12/11/2022 16:24, Aidan MacDonald wrote:
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
> 
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>

This is a resend? Or v2?

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base

Posted by Aidan MacDonald 3 years, 4 months ago

Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:

> On 12/11/2022 16:24, Aidan MacDonald wrote:
>> Remove use of the deprecated mask_invert flag. Inverted mask
>> registers (where a '1' bit enables an IRQ) can be described more
>> directly as an unmask register.
>>
>> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
>
> This is a resend? Or v2?
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof

It's a resend. The last submission couldn't be applied at the time
because of dependency troubles.