[PATCH 00/18] mfd: Clean up deprecated regmap-irq functionality

Aidan MacDonald posted 18 patches 3 years, 5 months ago
drivers/mfd/88pm800.c         |  3 +--
drivers/mfd/atc260x-core.c    |  6 ++----
drivers/mfd/axp20x.c          | 21 +++++++--------------
drivers/mfd/gateworks-gsc.c   |  3 +--
drivers/mfd/max14577.c        |  7 ++-----
drivers/mfd/max77650.c        |  1 -
drivers/mfd/max77693.c        |  6 +-----
drivers/mfd/max77843.c        |  1 -
drivers/mfd/rn5t618.c         |  3 +--
drivers/mfd/rohm-bd71828.c    |  6 ++----
drivers/mfd/rohm-bd718x7.c    |  1 -
drivers/mfd/rt5033.c          |  3 +--
drivers/mfd/rt5120.c          |  3 +--
drivers/mfd/sprd-sc27xx-spi.c |  3 +--
drivers/mfd/stpmic1.c         |  5 +++--
drivers/mfd/sun4i-gpadc.c     |  3 +--
drivers/mfd/tps65090.c        |  3 +--
drivers/mfd/wcd934x.c         | 11 ++++++++---
18 files changed, 33 insertions(+), 56 deletions(-)
[PATCH 00/18] mfd: Clean up deprecated regmap-irq functionality
Posted by Aidan MacDonald 3 years, 5 months ago
Hi Lee,

Here are some trivial updates to replace old, deprecated regmap-irq APIs
with the new equivalents. There should be no functional changes, but none
of the patches have been tested (besides compile testing).

One issue with WCD934x - after applying the patch, a bug in regmap-irq
will cause a null pointer deref when setting the IRQ type, but a fix is
already in the regmap tree.

Link: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/commit/?id=84498d1fb35de6ab71bdfdb6270a464fb4a0951b

Aidan MacDonald (18):
  mfd: 88pm800: Replace irqchip mask_invert with unmask_base
  mfd: atc260x: Replace irqchip mask_invert with unmask_base
  mfd: axp20x: Replace irqchip mask_invert with unmask_base
  mfd: gateworks-gsc: Replace irqchip mask_invert with unmask_base
  mfd: max14577: Replace irqchip mask_invert with unmask_base
  mfd: max77650: Remove useless type_invert flag
  mfd: max77693: Replace irqchip mask_invert with unmask_base
  mfd: max77843: Drop useless mask_invert flag on irqchip
  mfd: rn5t618: Replace irqchip mask_invert with unmask_base
  mfd: rohm-bd71828: Replace irqchip mask_invert with unmask_base
  mfd: rohm-bd718x7: Drop useless mask_invert flag on irqchip
  mfd: rt5033: Replace irqchip mask_invert with unmask_base
  mfd: rt5120: Replace irqchip mask_invert with unmask_base
  mfd: sprd-sc27xx-spi: Replace irqchip mask_invert with unmask_base
  mfd: stpmic1: Fix swapped mask/unmask in irq chip
  mfd: sun4i-gpadc: Replace irqchip mask_invert with unmask_base
  mfd: tps65090: Replace irqchip mask_invert with unmask_base
  mfd: wcd934x: Convert irq chip to config regs

 drivers/mfd/88pm800.c         |  3 +--
 drivers/mfd/atc260x-core.c    |  6 ++----
 drivers/mfd/axp20x.c          | 21 +++++++--------------
 drivers/mfd/gateworks-gsc.c   |  3 +--
 drivers/mfd/max14577.c        |  7 ++-----
 drivers/mfd/max77650.c        |  1 -
 drivers/mfd/max77693.c        |  6 +-----
 drivers/mfd/max77843.c        |  1 -
 drivers/mfd/rn5t618.c         |  3 +--
 drivers/mfd/rohm-bd71828.c    |  6 ++----
 drivers/mfd/rohm-bd718x7.c    |  1 -
 drivers/mfd/rt5033.c          |  3 +--
 drivers/mfd/rt5120.c          |  3 +--
 drivers/mfd/sprd-sc27xx-spi.c |  3 +--
 drivers/mfd/stpmic1.c         |  5 +++--
 drivers/mfd/sun4i-gpadc.c     |  3 +--
 drivers/mfd/tps65090.c        |  3 +--
 drivers/mfd/wcd934x.c         | 11 ++++++++---
 18 files changed, 33 insertions(+), 56 deletions(-)

-- 
2.38.1
Re: [PATCH 00/18] mfd: Clean up deprecated regmap-irq functionality
Posted by Matti Vaittinen 3 years, 4 months ago
Hi Aidan,

la 12. marrask. 2022 klo 17.19 Aidan MacDonald
(aidanmacdonald.0x0@gmail.com) kirjoitti:

> Here are some trivial updates to replace old, deprecated regmap-irq APIs
> with the new equivalents. There should be no functional changes, but none
> of the patches have been tested (besides compile testing).

> Link: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/commit/?id=84498d1fb35de6ab71bdfdb6270a464fb4a0951b
>
> Aidan MacDonald (18):

Just a small suggestion. Would it work if the CC-list was generated
separately for each of the patches for a large series targeted to
various individual drivers like this one? I think that many of the
recipients are not interested in more than one or two of the patches +
cover-letter in this 19-mail series...

I know it can be a pain to hassle with the recipient lists and
message-IDs - so I am glad if anyone can find some help from my
personal playground - or even better, share their versions with us :)
So, to open the window for any work-flow improvement suggestions...
...I've personally started generating patches using the following
shell-script (which is inefficient and lazily written but seems to
mostly work for me):
https://github.com/M-Vaittinen/linux/commit/9045670f8d3d4638b9032d96cff955704a6d438e

It can be freely used as a source of inspiration (or perspiration - no
guarantees it works as intended or is feasible for anything) when
generating the next series ;)

Yours
    -- Matti

-- 

Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

Discuss - Estimate - Plan - Report and finally accomplish this:
void do_work(int time) __attribute__ ((const));