[PATCH v1 net-next 0/2] cleanup ocelot_stats exposure

Colin Foster posted 2 patches 3 years, 5 months ago
There is a newer version of this series
drivers/net/dsa/ocelot/felix.c             |   1 -
drivers/net/dsa/ocelot/felix.h             |   1 -
drivers/net/dsa/ocelot/felix_vsc9959.c     |   5 -
drivers/net/dsa/ocelot/seville_vsc9953.c   |   5 -
drivers/net/ethernet/mscc/ocelot_stats.c   | 236 ++++++++++++++++++++-
drivers/net/ethernet/mscc/ocelot_vsc7514.c |   1 -
include/soc/mscc/ocelot.h                  | 216 -------------------
7 files changed, 228 insertions(+), 237 deletions(-)
[PATCH v1 net-next 0/2] cleanup ocelot_stats exposure
Posted by Colin Foster 3 years, 5 months ago
The ocelot_stats structures became redundant across all users. Replace
this redundancy with a static const struct. After doing this, several
definitions inside include/soc/mscc/ocelot.h no longer needed to be
shared. Patch 2 removes them.

Checkpatch throws an error for a complicated macro not in parentheses. I
understand the reason for OCELOT_COMMON_STATS was to allow expansion, but
interestingly this patch set is essentially reverting the ability for
expansion. I'm keeping the macro in this set, but am open to remove it,
since it doesn't _actually_ provide any immediate benefits anymore.

Colin Foster (2):
  net: mscc: ocelot: remove redundant stats_layout pointers
  net: mscc: ocelot: remove unnecessary exposure of stats structures

 drivers/net/dsa/ocelot/felix.c             |   1 -
 drivers/net/dsa/ocelot/felix.h             |   1 -
 drivers/net/dsa/ocelot/felix_vsc9959.c     |   5 -
 drivers/net/dsa/ocelot/seville_vsc9953.c   |   5 -
 drivers/net/ethernet/mscc/ocelot_stats.c   | 236 ++++++++++++++++++++-
 drivers/net/ethernet/mscc/ocelot_vsc7514.c |   1 -
 include/soc/mscc/ocelot.h                  | 216 -------------------
 7 files changed, 228 insertions(+), 237 deletions(-)

-- 
2.25.1