.../bindings/iio/addac/adi,ad74413r.yaml | 4 +- drivers/iio/addac/ad74413r.c | 51 +++++++++++++++---- 2 files changed, 43 insertions(+), 12 deletions(-)
These patches - fix a run-time warning - make the refin-supply optional in the binding - add a reset-gpios binding and update the driver to support the latter two. Rasmus Villemoes (5): iio: addac: ad74413r: add spi_device_id table dt-bindings: iio: ad74413r: make refin-supply optional iio: addac: ad74413r: implement support for optional refin-supply dt-bindings: iio: ad74413r: add optional reset-gpios iio: addac: ad74413r: add support for reset-gpio .../bindings/iio/addac/adi,ad74413r.yaml | 4 +- drivers/iio/addac/ad74413r.c | 51 +++++++++++++++---- 2 files changed, 43 insertions(+), 12 deletions(-) -- 2.37.2
Fix a run-time warning from the SPI core by providing a spi_device_id table, and add binding and driver support for a reset gpio. v2: - drop the two patches related to refin-supply - fall back to getting device data from the spi_device_id entry - update the example in the binding with a reset-gpios entry - fix a style nit Rasmus Villemoes (3): iio: addac: ad74413r: add spi_device_id table dt-bindings: iio: ad74413r: add optional reset-gpios iio: addac: ad74413r: add support for reset-gpio .../bindings/iio/addac/adi,ad74413r.yaml | 4 +++ drivers/iio/addac/ad74413r.c | 29 +++++++++++++++++++ 2 files changed, 33 insertions(+) -- 2.37.2
On Tue, 15 Nov 2022 10:55:14 +0100 Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote: > Fix a run-time warning from the SPI core by providing a spi_device_id > table, and add binding and driver support for a reset gpio. > > v2: > - drop the two patches related to refin-supply > - fall back to getting device data from the spi_device_id entry > - update the example in the binding with a reset-gpios entry > - fix a style nit Series applied to the togreg branch of iio.git. They might get one day soaking as testing before I push them out to get some linux-next coverage or I might skip that bit. Thanks, Jonathan > > Rasmus Villemoes (3): > iio: addac: ad74413r: add spi_device_id table > dt-bindings: iio: ad74413r: add optional reset-gpios > iio: addac: ad74413r: add support for reset-gpio > > .../bindings/iio/addac/adi,ad74413r.yaml | 4 +++ > drivers/iio/addac/ad74413r.c | 29 +++++++++++++++++++ > 2 files changed, 33 insertions(+) >
Silence the run-time warning
SPI driver ad74413r has no spi_device_id for adi,ad74412r
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/iio/addac/ad74413r.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
index 899bcd83f40b..a157f2247a50 100644
--- a/drivers/iio/addac/ad74413r.c
+++ b/drivers/iio/addac/ad74413r.c
@@ -1305,6 +1305,15 @@ static int ad74413r_probe(struct spi_device *spi)
st->spi = spi;
st->dev = &spi->dev;
st->chip_info = device_get_match_data(&spi->dev);
+ if (!st->chip_info) {
+ const struct spi_device_id *id = spi_get_device_id(spi);
+ if (id)
+ st->chip_info =
+ (struct ad74413r_chip_info *)id->driver_data;
+ if (!st->chip_info)
+ return -EINVAL;
+ }
+
mutex_init(&st->lock);
init_completion(&st->adc_data_completion);
@@ -1457,12 +1466,20 @@ static const struct of_device_id ad74413r_dt_id[] = {
};
MODULE_DEVICE_TABLE(of, ad74413r_dt_id);
+static const struct spi_device_id ad74413r_spi_id[] = {
+ { .name = "ad74412r", .driver_data = (kernel_ulong_t)&ad74412r_chip_info_data },
+ { .name = "ad74413r", .driver_data = (kernel_ulong_t)&ad74413r_chip_info_data },
+ {}
+};
+MODULE_DEVICE_TABLE(spi, ad74413r_spi_id);
+
static struct spi_driver ad74413r_driver = {
.driver = {
.name = "ad74413r",
.of_match_table = ad74413r_dt_id,
},
.probe = ad74413r_probe,
+ .id_table = ad74413r_spi_id,
};
module_driver(ad74413r_driver,
--
2.37.2The ad74412 and ad74413 devices have an active-low reset pin. Add a
binding allowing one to specify a gpio tied to that.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml
index 03bb90a7f4f8..62f446dbc3d8 100644
--- a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml
+++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml
@@ -51,6 +51,9 @@ properties:
Shunt (sense) resistor value in micro-Ohms.
default: 100000000
+ reset-gpios:
+ maxItems: 1
+
required:
- compatible
- reg
@@ -129,6 +132,7 @@ examples:
interrupts = <26 IRQ_TYPE_EDGE_FALLING>;
refin-supply = <&ad74413r_refin>;
+ reset-gpios = <&gpio2 6 GPIO_ACTIVE_LOW>;
channel@0 {
reg = <0>;
--
2.37.2On 15/11/2022 10:55, Rasmus Villemoes wrote: > The ad74412 and ad74413 devices have an active-low reset pin. Add a > binding allowing one to specify a gpio tied to that. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
We have a board where the reset pin of the ad74412 is connected to a
gpio, but also pulled low (i.e., asserted) by default. Hence to get
the chip out of reset, the driver needs to know about that gpio and
deassert the reset signal before attempting to communicate with the
chip.
When a reset-gpio is given in device tree, use that instead of the
software reset. According to the data sheet, the two methods are
functionally equivalent.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/iio/addac/ad74413r.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
index a157f2247a50..313c279173f2 100644
--- a/drivers/iio/addac/ad74413r.c
+++ b/drivers/iio/addac/ad74413r.c
@@ -71,6 +71,7 @@ struct ad74413r_state {
struct regmap *regmap;
struct device *dev;
struct iio_trigger *trig;
+ struct gpio_desc *reset_gpio;
size_t adc_active_channels;
struct spi_message adc_samples_msg;
@@ -393,6 +394,13 @@ static int ad74413r_reset(struct ad74413r_state *st)
{
int ret;
+ if (st->reset_gpio) {
+ gpiod_set_value_cansleep(st->reset_gpio, 1);
+ fsleep(50);
+ gpiod_set_value_cansleep(st->reset_gpio, 0);
+ return 0;
+ }
+
ret = regmap_write(st->regmap, AD74413R_REG_CMD_KEY,
AD74413R_CMD_KEY_RESET1);
if (ret)
@@ -1322,6 +1330,10 @@ static int ad74413r_probe(struct spi_device *spi)
if (IS_ERR(st->regmap))
return PTR_ERR(st->regmap);
+ st->reset_gpio = devm_gpiod_get_optional(st->dev, "reset", GPIOD_OUT_LOW);
+ if (IS_ERR(st->reset_gpio))
+ return PTR_ERR(st->reset_gpio);
+
st->refin_reg = devm_regulator_get(st->dev, "refin");
if (IS_ERR(st->refin_reg))
return dev_err_probe(st->dev, PTR_ERR(st->refin_reg),
--
2.37.2© 2016 - 2026 Red Hat, Inc.