[PATCH v7 2/3] xhci: hub: export symbol on xhci_hub_control

Jim Lin posted 3 patches 3 years, 4 months ago
[PATCH v7 2/3] xhci: hub: export symbol on xhci_hub_control
Posted by Jim Lin 3 years, 4 months ago
XHCI host drivers may override the default xhci_hub_control() with
their own device specific function. To allow these host drivers to
call the xhci_hub_control() function from within their own
hub_control() callback and be built as a module, export the symbol
for xhci_hub_control.

Signed-off-by: Jim Lin <jilin@nvidia.com>

---
v5: new change
v6: modify commit message
v7: change commit message

 drivers/usb/host/xhci-hub.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index af946c42b6f0..4f20cdae2a89 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
@@ -1604,6 +1604,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
 	spin_unlock_irqrestore(&xhci->lock, flags);
 	return retval;
 }
+EXPORT_SYMBOL_GPL(xhci_hub_control);
 
 /*
  * Returns 0 if the status hasn't changed, or the number of bytes in buf.
-- 
2.17.1
Re: [PATCH v7 2/3] xhci: hub: export symbol on xhci_hub_control
Posted by Thierry Reding 3 years, 4 months ago
On Fri, Nov 11, 2022 at 06:18:12PM +0800, Jim Lin wrote:
> XHCI host drivers may override the default xhci_hub_control() with
> their own device specific function. To allow these host drivers to
> call the xhci_hub_control() function from within their own
> hub_control() callback and be built as a module, export the symbol
> for xhci_hub_control.
> 
> Signed-off-by: Jim Lin <jilin@nvidia.com>
> 
> ---
> v5: new change
> v6: modify commit message
> v7: change commit message
> 
>  drivers/usb/host/xhci-hub.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Thierry Reding <treding@nvidia.com>
Re: [PATCH v7 2/3] xhci: hub: export symbol on xhci_hub_control
Posted by Jon Hunter 3 years, 4 months ago
On 11/11/2022 10:18, Jim Lin wrote:
> XHCI host drivers may override the default xhci_hub_control() with
> their own device specific function. To allow these host drivers to
> call the xhci_hub_control() function from within their own
> hub_control() callback and be built as a module, export the symbol
> for xhci_hub_control.
> 
> Signed-off-by: Jim Lin <jilin@nvidia.com>
> 
> ---
> v5: new change
> v6: modify commit message
> v7: change commit message
> 
>   drivers/usb/host/xhci-hub.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
> index af946c42b6f0..4f20cdae2a89 100644
> --- a/drivers/usb/host/xhci-hub.c
> +++ b/drivers/usb/host/xhci-hub.c
> @@ -1604,6 +1604,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
>   	spin_unlock_irqrestore(&xhci->lock, flags);
>   	return retval;
>   }
> +EXPORT_SYMBOL_GPL(xhci_hub_control);
>   
>   /*
>    * Returns 0 if the status hasn't changed, or the number of bytes in buf.

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic