dt-bindings: thermal: cooling-devices: Add missing cache related properties

[PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties

Posted by Rob Herring 3 years, 5 months ago

The examples' cache nodes are incomplete as 'cache-unified' and
'cache-level' are required cache properties.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/thermal/thermal-cooling-devices.yaml  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
index 850a9841b110..7bb9327caa13 100644
--- a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
+++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
@@ -76,9 +76,13 @@ examples:
                     next-level-cache = <&L2_0>;
                     L2_0: l2-cache {
                             compatible = "cache";
+                            cache-unified;
+                            cache-level = <2>;
                             next-level-cache = <&L3_0>;
                             L3_0: l3-cache {
                                     compatible = "cache";
+                                    cache-unified;
+                                    cache-level = <3>;
                             };
                     };
           };
-- 
2.35.1

Re: [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties

Posted by Rob Herring 3 years, 4 months ago

On Fri, 04 Nov 2022 11:24:50 -0500, Rob Herring wrote:
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/thermal/thermal-cooling-devices.yaml  | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Applied, thanks!

Re: [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties

Posted by Amit Kucheria 3 years, 5 months ago

On Fri, Nov 4, 2022 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
>
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Amit Kucheria <amitk@kernel.org>

> ---
>  .../devicetree/bindings/thermal/thermal-cooling-devices.yaml  | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> index 850a9841b110..7bb9327caa13 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> +++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> @@ -76,9 +76,13 @@ examples:
>                      next-level-cache = <&L2_0>;
>                      L2_0: l2-cache {
>                              compatible = "cache";
> +                            cache-unified;
> +                            cache-level = <2>;
>                              next-level-cache = <&L3_0>;
>                              L3_0: l3-cache {
>                                      compatible = "cache";
> +                                    cache-unified;
> +                                    cache-level = <3>;
>                              };
>                      };
>            };
> --
> 2.35.1
>

Re: [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties

Posted by Krzysztof Kozlowski 3 years, 5 months ago

On 04/11/2022 17:24, Rob Herring wrote:
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof