scsi: ufs: Remove check_upiu_size() from ufshcd.h

[PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h

Posted by Keoseong Park 3 years, 5 months ago

Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate
device initialization") added check_upiu_size(), but no caller.

Cc: Dolev Raviv <draviv@codeaurora.org>
Signed-off-by: Keoseong Park <keosung.park@samsung.com>
---
 include/ufs/ufshcd.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
index 96538eb3a6c0..5cf81dff60aa 100644
--- a/include/ufs/ufshcd.h
+++ b/include/ufs/ufshcd.h
@@ -1072,12 +1072,6 @@ void ufshcd_update_evt_hist(struct ufs_hba *hba, u32 id, u32 val);
 void ufshcd_hba_stop(struct ufs_hba *hba);
 void ufshcd_schedule_eh_work(struct ufs_hba *hba);
 
-static inline void check_upiu_size(void)
-{
-	BUILD_BUG_ON(ALIGNED_UPIU_SIZE <
-		GENERAL_UPIU_REQUEST_SIZE + QUERY_DESC_MAX_SIZE);
-}
-
 /**
  * ufshcd_set_variant - set variant specific data to the hba
  * @hba: per adapter instance
-- 
2.17.1

Re: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h

Posted by Martin K. Petersen 3 years, 4 months ago

On Thu, 03 Nov 2022 14:53:49 +0900, Keoseong Park wrote:

> Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate
> device initialization") added check_upiu_size(), but no caller.
> 
> 

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: ufs: Remove check_upiu_size() from ufshcd.h
      https://git.kernel.org/mkp/scsi/c/3d6d7930928a

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h

Posted by Martin K. Petersen 3 years, 5 months ago

Keoseong,

> Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate
> device initialization") added check_upiu_size(), but no caller.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

RE: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h

Posted by Avri Altman 3 years, 5 months ago

> Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate device
> initialization") added check_upiu_size(), but no caller.
Nor there ever was.

> 
> Cc: Dolev Raviv <draviv@codeaurora.org>
> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  include/ufs/ufshcd.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h index
> 96538eb3a6c0..5cf81dff60aa 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -1072,12 +1072,6 @@ void ufshcd_update_evt_hist(struct ufs_hba *hba,
> u32 id, u32 val);  void ufshcd_hba_stop(struct ufs_hba *hba);  void
> ufshcd_schedule_eh_work(struct ufs_hba *hba);
> 
> -static inline void check_upiu_size(void) -{
> -       BUILD_BUG_ON(ALIGNED_UPIU_SIZE <
> -               GENERAL_UPIU_REQUEST_SIZE + QUERY_DESC_MAX_SIZE);
> -}
> -
>  /**
>   * ufshcd_set_variant - set variant specific data to the hba
>   * @hba: per adapter instance
> --
> 2.17.1