.../devicetree/bindings/power/supply/bq25890.yaml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
BQ2589[0256] seem compatible between each other in major aspects and
remaining features are auto-detectable (by reading device revision ID
register). Existing DTS already uses the compatibles with a fallback,
so adjust the bindings to reflect this and fix dtbs_check warning:
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb: charger@6a: compatible: ['ti,bq25895', 'ti,bq25890'] is too long
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/power/supply/bq25890.yaml | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.yaml b/Documentation/devicetree/bindings/power/supply/bq25890.yaml
index fd01ff10b4e0..ee51b6335e72 100644
--- a/Documentation/devicetree/bindings/power/supply/bq25890.yaml
+++ b/Documentation/devicetree/bindings/power/supply/bq25890.yaml
@@ -15,11 +15,15 @@ allOf:
properties:
compatible:
- enum:
- - ti,bq25890
- - ti,bq25892
- - ti,bq25895
- - ti,bq25896
+ oneOf:
+ - enum:
+ - ti,bq25890
+ - items:
+ - enum:
+ - ti,bq25892
+ - ti,bq25895
+ - ti,bq25896
+ - const: ti,bq25890
reg:
maxItems: 1
--
2.34.1
On Wed, 02 Nov 2022 14:20:11 -0400, Krzysztof Kozlowski wrote: > BQ2589[0256] seem compatible between each other in major aspects and > remaining features are auto-detectable (by reading device revision ID > register). Existing DTS already uses the compatibles with a fallback, > so adjust the bindings to reflect this and fix dtbs_check warning: > > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb: charger@6a: compatible: ['ti,bq25895', 'ti,bq25890'] is too long > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/power/supply/bq25890.yaml | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi, On Fri, Nov 04, 2022 at 04:53:14PM -0500, Rob Herring wrote: > On Wed, 02 Nov 2022 14:20:11 -0400, Krzysztof Kozlowski wrote: > > BQ2589[0256] seem compatible between each other in major aspects and > > remaining features are auto-detectable (by reading device revision ID > > register). Existing DTS already uses the compatibles with a fallback, > > so adjust the bindings to reflect this and fix dtbs_check warning: > > > > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb: charger@6a: compatible: ['ti,bq25895', 'ti,bq25890'] is too long > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > .../devicetree/bindings/power/supply/bq25890.yaml | 14 +++++++++----- > > 1 file changed, 9 insertions(+), 5 deletions(-) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Thanks, queued. -- Sebastian
© 2016 - 2026 Red Hat, Inc.