[PATCH net] net: bcmsysport: Indicate MAC is in charge of PHY PM

Florian Fainelli posted 1 patch 3 years, 5 months ago
drivers/net/ethernet/broadcom/bcmsysport.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH net] net: bcmsysport: Indicate MAC is in charge of PHY PM
Posted by Florian Fainelli 3 years, 5 months ago
Avoid the PHY library call unnecessarily into the suspend/resume
functions by setting phydev->mac_managed_pm to true. The SYSTEMPORT
driver essentially does exactly what mdio_bus_phy_resume() does by
calling phy_resume().

Fixes: fba863b81604 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/ethernet/broadcom/bcmsysport.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index 867f14c30e09..425d6ccd5413 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -1991,6 +1991,9 @@ static int bcm_sysport_open(struct net_device *dev)
 		goto out_clk_disable;
 	}
 
+	/* Indicate that the MAC is responsible for PHY PM */
+	phydev->mac_managed_pm = true;
+
 	/* Reset house keeping link status */
 	priv->old_duplex = -1;
 	priv->old_link = -1;
-- 
2.25.1
Re: [PATCH net] net: bcmsysport: Indicate MAC is in charge of PHY PM
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 5 months ago
Hello:

This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 25 Oct 2022 16:42:01 -0700 you wrote:
> Avoid the PHY library call unnecessarily into the suspend/resume
> functions by setting phydev->mac_managed_pm to true. The SYSTEMPORT
> driver essentially does exactly what mdio_bus_phy_resume() does by
> calling phy_resume().
> 
> Fixes: fba863b81604 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net] net: bcmsysport: Indicate MAC is in charge of PHY PM
    https://git.kernel.org/netdev/net/c/9f172134dde7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html