maple_tree: Update copyright dates for test code

[PATCH] maple_tree: Update copyright dates for test code

Posted by Liam Howlett 3 years, 1 month ago

Add the span to the year of the development.

Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 tools/testing/radix-tree/maple.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
index 35082671928a..3620c9e5f7c5 100644
--- a/tools/testing/radix-tree/maple.c
+++ b/tools/testing/radix-tree/maple.c
@@ -1,7 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * maple_tree.c: Userspace shim for maple tree test-suite
- * Copyright (c) 2018 Liam R. Howlett <Liam.Howlett@Oracle.com>
+ * maple_tree.c: Userspace testing for maple tree test-suite
+ * Copyright (c) 2018-2022 Oracle Corporation
+ * Author: Liam R. Howlett <Liam.Howlett@Oracle.com>
  */
 
 #define CONFIG_DEBUG_MAPLE_TREE
-- 
2.35.1

Re: [PATCH] maple_tree: Update copyright dates for test code

Posted by Joe Perches 3 years, 1 month ago

On Tue, 2022-10-25 at 17:37 +0000, Liam Howlett wrote:
> Add the span to the year of the development.
> 
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
>  tools/testing/radix-tree/maple.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
> index 35082671928a..3620c9e5f7c5 100644
> --- a/tools/testing/radix-tree/maple.c
> +++ b/tools/testing/radix-tree/maple.c
> @@ -1,7 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0+
>  /*
> - * maple_tree.c: Userspace shim for maple tree test-suite
> - * Copyright (c) 2018 Liam R. Howlett <Liam.Howlett@Oracle.com>
> + * maple_tree.c: Userspace testing for maple tree test-suite
> + * Copyright (c) 2018-2022 Oracle Corporation
> + * Author: Liam R. Howlett <Liam.Howlett@Oracle.com>

Confused here.  Who owns the copyright from 2018?

And what happened from 2019 through 2021 ?

$ git log --stat -p -1 54a611b605901c7d5d05b6b8f5d04a6ceb0962aa | grep -i copyright
+ * Copyright (c) 2018-2022 Oracle
+ * Copyright (c) 2018-2022 Oracle Corporation
+ * Copyright (c) 2018 Liam R. Howlett <Liam.Howlett@Oracle.com>

Re: [PATCH] maple_tree: Update copyright dates for test code

Posted by Liam Howlett 3 years, 1 month ago

* Joe Perches <joe@perches.com> [221025 14:06]:
> On Tue, 2022-10-25 at 17:37 +0000, Liam Howlett wrote:
> > Add the span to the year of the development.
> > 
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> > ---
> >  tools/testing/radix-tree/maple.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
> > index 35082671928a..3620c9e5f7c5 100644
> > --- a/tools/testing/radix-tree/maple.c
> > +++ b/tools/testing/radix-tree/maple.c
> > @@ -1,7 +1,8 @@
> >  // SPDX-License-Identifier: GPL-2.0+
> >  /*
> > - * maple_tree.c: Userspace shim for maple tree test-suite
> > - * Copyright (c) 2018 Liam R. Howlett <Liam.Howlett@Oracle.com>
> > + * maple_tree.c: Userspace testing for maple tree test-suite
> > + * Copyright (c) 2018-2022 Oracle Corporation
> > + * Author: Liam R. Howlett <Liam.Howlett@Oracle.com>
> 
> Confused here.  Who owns the copyright from 2018?

2018 should have also been oracle on this file.  Note the email
address.

> 
> And what happened from 2019 through 2021 ?

Development continued which is why I wanted to extend the date to a
range.  I also presented the maple tree and spoke to a lot of people
about it.  Also a pandemic, I hear.

> 
> $ git log --stat -p -1 54a611b605901c7d5d05b6b8f5d04a6ceb0962aa | grep -i copyright
> + * Copyright (c) 2018-2022 Oracle
> + * Copyright (c) 2018-2022 Oracle Corporation
> + * Copyright (c) 2018 Liam R. Howlett <Liam.Howlett@Oracle.com>
> 

Right, this is what I am correcting.  I'm not sure what you are getting
at here.  Did I do something incorrect with trying to fix my mistake?

Thanks,
Liam

Re: [PATCH] maple_tree: Update copyright dates for test code

Posted by Joe Perches 3 years, 1 month ago

On Tue, 2022-10-25 at 20:23 +0000, Liam Howlett wrote:
> * Joe Perches <joe@perches.com> [221025 14:06]:
> > On Tue, 2022-10-25 at 17:37 +0000, Liam Howlett wrote:
> > > Add the span to the year of the development.
[]
> > > diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
[]
> > > @@ -1,7 +1,8 @@
> > >  // SPDX-License-Identifier: GPL-2.0+
> > >  /*
> > > - * maple_tree.c: Userspace shim for maple tree test-suite
> > > - * Copyright (c) 2018 Liam R. Howlett <Liam.Howlett@Oracle.com>
> > > + * maple_tree.c: Userspace testing for maple tree test-suite
> > > + * Copyright (c) 2018-2022 Oracle Corporation
> > > + * Author: Liam R. Howlett <Liam.Howlett@Oracle.com>
> > 
> > Confused here.  Who owns the copyright from 2018?
> 
> 2018 should have also been oracle on this file.  Note the email
> address.

Noted.  It shows you as the copyright holder not Oracle Corp.

You are reassigning copyright yet the commit message merely shows
additional "span".

> > And what happened from 2019 through 2021 ?

When work on a object does not occur during a year, it
should not be included in a copyright "span".

> Development continued which is why I wanted to extend the date to a
> range.  I also presented the maple tree and spoke to a lot of people
> about it.  Also a pandemic, I hear.

Not a reason for copyright changes, but whatever...

> > $ git log --stat -p -1 54a611b605901c7d5d05b6b8f5d04a6ceb0962aa | grep -i copyright
> > + * Copyright (c) 2018-2022 Oracle
> > + * Copyright (c) 2018-2022 Oracle Corporation
> > + * Copyright (c) 2018 Liam R. Howlett <Liam.Howlett@Oracle.com>
> 
> Right, this is what I am correcting.  I'm not sure what you are getting
> at here.

Just inconsistency.
First shows only Oracle, second is Oracle Corporation.

>  Did I do something incorrect with trying to fix my mistake?

Copyright reassignment not specified in commit message.

cheers, Joe

Re: [PATCH] maple_tree: Update copyright dates for test code

Posted by Matthew Wilcox 3 years, 1 month ago

On Tue, Oct 25, 2022 at 01:40:19PM -0700, Joe Perches wrote:
> Copyright reassignment not specified in commit message.

It's not copyright reassignment.  Liam has been an employee of Oracle
for the entire duration.  It is fixing the copyright notice to be correct.

Re: [PATCH] maple_tree: Update copyright dates for test code

Posted by Joe Perches 3 years, 1 month ago

On Tue, 2022-10-25 at 22:15 +0100, Matthew Wilcox wrote:
> On Tue, Oct 25, 2022 at 01:40:19PM -0700, Joe Perches wrote:
> > Copyright reassignment not specified in commit message.
> 
> It's not copyright reassignment.  Liam has been an employee of Oracle
> for the entire duration.  It is fixing the copyright notice to be correct.

Perhaps.

But it would definitely be better if the subject and message matched
the change.

All the suggested commit subject and message states is

> maple_tree: Update copyright dates for test code

and

> Add the span to the year of the development.

The patch itself does not do that.

On its face, it's reassigning copyright, not suggesting the original
copyright owner was in error.