[PATCH] nvmem: lan9662-otp: fix compatible name

Claudiu Beznea posted 1 patch 3 years, 5 months ago
drivers/nvmem/lan9662-otpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] nvmem: lan9662-otp: fix compatible name
Posted by Claudiu Beznea 3 years, 5 months ago
Documentation of lan9662-otpc driver (namely Documentation/\
devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml) express that
compatible for this driver contains "otpc" string at the end but not "otp"
as currently present. Fix this typo.

Fixes: 9e8f208ad522 ("nvmem: lan9662-otp: add support")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 drivers/nvmem/lan9662-otpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvmem/lan9662-otpc.c b/drivers/nvmem/lan9662-otpc.c
index f6732fd216d8..377bf34c2946 100644
--- a/drivers/nvmem/lan9662-otpc.c
+++ b/drivers/nvmem/lan9662-otpc.c
@@ -203,7 +203,7 @@ static int lan9662_otp_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id lan9662_otp_match[] = {
-	{ .compatible = "microchip,lan9662-otp", },
+	{ .compatible = "microchip,lan9662-otpc", },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, lan9662_otp_match);
-- 
2.34.1
Re: [PATCH] nvmem: lan9662-otp: fix compatible name
Posted by Horatiu Vultur 3 years, 5 months ago
The 10/25/2022 10:22, Claudiu Beznea wrote:

Hi Claudiu,

> Documentation of lan9662-otpc driver (namely Documentation/\
> devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml) express that
> compatible for this driver contains "otpc" string at the end but not "otp"
> as currently present. Fix this typo.

Thanks for this patch.
I have also sent a patch for this some time ago[1], but there
is no reply on this.

Anyway for this patch:

Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>

[1] https://patchew.org/linux/20220928195112.630351-1-horatiu.vultur@microchip.com/

> 
> Fixes: 9e8f208ad522 ("nvmem: lan9662-otp: add support")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
>  drivers/nvmem/lan9662-otpc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/lan9662-otpc.c b/drivers/nvmem/lan9662-otpc.c
> index f6732fd216d8..377bf34c2946 100644
> --- a/drivers/nvmem/lan9662-otpc.c
> +++ b/drivers/nvmem/lan9662-otpc.c
> @@ -203,7 +203,7 @@ static int lan9662_otp_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id lan9662_otp_match[] = {
> -	{ .compatible = "microchip,lan9662-otp", },
> +	{ .compatible = "microchip,lan9662-otpc", },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, lan9662_otp_match);
> -- 
> 2.34.1
> 

-- 
/Horatiu
Re: [PATCH] nvmem: lan9662-otp: fix compatible name
Posted by Greg KH 3 years, 4 months ago
On Wed, Oct 26, 2022 at 01:44:05AM +0200, Horatiu Vultur wrote:
> The 10/25/2022 10:22, Claudiu Beznea wrote:
> 
> Hi Claudiu,
> 
> > Documentation of lan9662-otpc driver (namely Documentation/\
> > devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml) express that
> > compatible for this driver contains "otpc" string at the end but not "otp"
> > as currently present. Fix this typo.
> 
> Thanks for this patch.
> I have also sent a patch for this some time ago[1], but there
> is no reply on this.
> 
> Anyway for this patch:
> 
> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> 
> [1] https://patchew.org/linux/20220928195112.630351-1-horatiu.vultur@microchip.com/

I have queued up your first patch as you were here first, thanks.

greg k-h