irqchip: Allow test compilation of Broadcom drivers

[PATCH] irqchip: Allow test compilation of Broadcom drivers

Posted by Florian Fainelli 3 years, 5 months ago

Allow test compilation of the Broadcom irqchip drivers by adding a
COMPILE_TEST dependency.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/irqchip/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 7ef9f5e696d3..e4b2ec9b2450 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -116,7 +116,7 @@ config BCM6345_L1_IRQ
 
 config BCM7038_L1_IRQ
 	tristate "Broadcom STB 7038-style L1/L2 interrupt controller driver"
-	depends on ARCH_BRCMSTB || BMIPS_GENERIC
+	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
 	default ARCH_BRCMSTB || BMIPS_GENERIC
 	select GENERIC_IRQ_CHIP
 	select IRQ_DOMAIN
@@ -124,14 +124,14 @@ config BCM7038_L1_IRQ
 
 config BCM7120_L2_IRQ
 	tristate "Broadcom STB 7120-style L2 interrupt controller driver"
-	depends on ARCH_BRCMSTB || BMIPS_GENERIC
+	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
 	default ARCH_BRCMSTB || BMIPS_GENERIC
 	select GENERIC_IRQ_CHIP
 	select IRQ_DOMAIN
 
 config BRCMSTB_L2_IRQ
 	tristate "Broadcom STB generic L2 interrupt controller driver"
-	depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC
+	depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
 	default ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC
 	select GENERIC_IRQ_CHIP
 	select IRQ_DOMAIN
-- 
2.25.1

Re: [PATCH] irqchip: Allow test compilation of Broadcom drivers

Posted by Marc Zyngier 3 years, 4 months ago

On Mon, 24 Oct 2022 23:27:39 +0100,
Florian Fainelli <f.fainelli@gmail.com> wrote:
> 
> Allow test compilation of the Broadcom irqchip drivers by adding a
> COMPILE_TEST dependency.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  drivers/irqchip/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 7ef9f5e696d3..e4b2ec9b2450 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -116,7 +116,7 @@ config BCM6345_L1_IRQ
>  
>  config BCM7038_L1_IRQ
>  	tristate "Broadcom STB 7038-style L1/L2 interrupt controller driver"
> -	depends on ARCH_BRCMSTB || BMIPS_GENERIC
> +	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST

Do we actually need all this churn now that OF is user-selectable (see
0166dc11be91)?

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH] irqchip: Allow test compilation of Broadcom drivers

Posted by Florian Fainelli 3 years, 4 months ago


On 11/26/2022 5:26 AM, Marc Zyngier wrote:
> On Mon, 24 Oct 2022 23:27:39 +0100,
> Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>> Allow test compilation of the Broadcom irqchip drivers by adding a
>> COMPILE_TEST dependency.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>>   drivers/irqchip/Kconfig | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 7ef9f5e696d3..e4b2ec9b2450 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -116,7 +116,7 @@ config BCM6345_L1_IRQ
>>   
>>   config BCM7038_L1_IRQ
>>   	tristate "Broadcom STB 7038-style L1/L2 interrupt controller driver"
>> -	depends on ARCH_BRCMSTB || BMIPS_GENERIC
>> +	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> 
> Do we actually need all this churn now that OF is user-selectable (see
> 0166dc11be91)?

Seems to me that we would since that allows people to choose the 
building of these drivers rather than lift the dependencies and replace 
it with:

depends on OF

as this would prompt many users about drivers they do not care about.
-- 
Florian