mmc: sdhci-brcmstb: Allow building with COMPILE_TEST

[PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST

Posted by Brian Norris 3 years, 5 months ago

This driver is pretty simple, and it can be useful to build it (for
validation purposes) without BMIPS or ARCH_BRCMSTB.

It technically depends on CONFIG_OF to do anything useful at runtime,
but it still works out OK for compile-testing using the !OF stubs.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---

 drivers/mmc/host/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index f324daadaf70..453fba8d2d9d 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -1040,10 +1040,10 @@ config MMC_SDHCI_MICROCHIP_PIC32
 
 config MMC_SDHCI_BRCMSTB
 	tristate "Broadcom SDIO/SD/MMC support"
-	depends on ARCH_BRCMSTB || BMIPS_GENERIC
+	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
 	depends on MMC_SDHCI_PLTFM
 	select MMC_CQHCI
-	default y
+	default ARCH_BRCMSTB || BMIPS_GENERIC
 	help
 	  This selects support for the SDIO/SD/MMC Host Controller on
 	  Broadcom STB SoCs.
-- 
2.38.0.135.g90850a2211-goog

Re: [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST

Posted by Ulf Hansson 3 years, 5 months ago

On Mon, 24 Oct 2022 at 20:18, Brian Norris <briannorris@chromium.org> wrote:
>
> This driver is pretty simple, and it can be useful to build it (for
> validation purposes) without BMIPS or ARCH_BRCMSTB.
>
> It technically depends on CONFIG_OF to do anything useful at runtime,
> but it still works out OK for compile-testing using the !OF stubs.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>
>  drivers/mmc/host/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f324daadaf70..453fba8d2d9d 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1040,10 +1040,10 @@ config MMC_SDHCI_MICROCHIP_PIC32
>
>  config MMC_SDHCI_BRCMSTB
>         tristate "Broadcom SDIO/SD/MMC support"
> -       depends on ARCH_BRCMSTB || BMIPS_GENERIC
> +       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>         depends on MMC_SDHCI_PLTFM
>         select MMC_CQHCI
> -       default y
> +       default ARCH_BRCMSTB || BMIPS_GENERIC
>         help
>           This selects support for the SDIO/SD/MMC Host Controller on
>           Broadcom STB SoCs.
> --
> 2.38.0.135.g90850a2211-goog
>

Re: [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST

Posted by Adrian Hunter 3 years, 5 months ago

On 24/10/22 21:17, Brian Norris wrote:
> This driver is pretty simple, and it can be useful to build it (for
> validation purposes) without BMIPS or ARCH_BRCMSTB.
> 
> It technically depends on CONFIG_OF to do anything useful at runtime,
> but it still works out OK for compile-testing using the !OF stubs.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> 
>  drivers/mmc/host/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f324daadaf70..453fba8d2d9d 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1040,10 +1040,10 @@ config MMC_SDHCI_MICROCHIP_PIC32
>  
>  config MMC_SDHCI_BRCMSTB
>  	tristate "Broadcom SDIO/SD/MMC support"
> -	depends on ARCH_BRCMSTB || BMIPS_GENERIC
> +	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>  	depends on MMC_SDHCI_PLTFM
>  	select MMC_CQHCI
> -	default y
> +	default ARCH_BRCMSTB || BMIPS_GENERIC
>  	help
>  	  This selects support for the SDIO/SD/MMC Host Controller on
>  	  Broadcom STB SoCs.

Re: [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST

Posted by Florian Fainelli 3 years, 5 months ago

On 10/24/22 11:17, Brian Norris wrote:
> This driver is pretty simple, and it can be useful to build it (for
> validation purposes) without BMIPS or ARCH_BRCMSTB.
> 
> It technically depends on CONFIG_OF to do anything useful at runtime,
> but it still works out OK for compile-testing using the !OF stubs.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Yeah, really no reason not to let you build it, thanks Brian!
-- 
Florian