mmc: sdhci_am654: 'select', not 'depends' REGMAP_MMIO

[PATCH] mmc: sdhci_am654: 'select', not 'depends' REGMAP_MMIO

Posted by Brian Norris 3 years, 5 months ago

REGMAP_MMIO is not user-configurable, so we can only satisfy this
dependency by enabling some other Kconfig symbol that properly 'select's
it.

Use select like everybody else.

Noticed when trying to enable this driver for compile testing.

Fixes: 59592cc1f593 ("mmc: sdhci_am654: Add dependency on MMC_SDHCI_AM654")
Signed-off-by: Brian Norris <briannorris@chromium.org>
---

 drivers/mmc/host/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index f324daadaf70..fb1062a6394c 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -1075,9 +1075,10 @@ config MMC_SDHCI_OMAP
 
 config MMC_SDHCI_AM654
 	tristate "Support for the SDHCI Controller in TI's AM654 SOCs"
-	depends on MMC_SDHCI_PLTFM && OF && REGMAP_MMIO
+	depends on MMC_SDHCI_PLTFM && OF
 	select MMC_SDHCI_IO_ACCESSORS
 	select MMC_CQHCI
+	select REGMAP_MMIO
 	help
 	  This selects the Secure Digital Host Controller Interface (SDHCI)
 	  support present in TI's AM654 SOCs. The controller supports
-- 
2.38.0.135.g90850a2211-goog

Re: [PATCH] mmc: sdhci_am654: 'select', not 'depends' REGMAP_MMIO

Posted by Ulf Hansson 3 years, 5 months ago

On Mon, 24 Oct 2022 at 20:03, Brian Norris <briannorris@chromium.org> wrote:
>
> REGMAP_MMIO is not user-configurable, so we can only satisfy this
> dependency by enabling some other Kconfig symbol that properly 'select's
> it.
>
> Use select like everybody else.
>
> Noticed when trying to enable this driver for compile testing.
>
> Fixes: 59592cc1f593 ("mmc: sdhci_am654: Add dependency on MMC_SDHCI_AM654")
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe


> ---
>
>  drivers/mmc/host/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f324daadaf70..fb1062a6394c 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1075,9 +1075,10 @@ config MMC_SDHCI_OMAP
>
>  config MMC_SDHCI_AM654
>         tristate "Support for the SDHCI Controller in TI's AM654 SOCs"
> -       depends on MMC_SDHCI_PLTFM && OF && REGMAP_MMIO
> +       depends on MMC_SDHCI_PLTFM && OF
>         select MMC_SDHCI_IO_ACCESSORS
>         select MMC_CQHCI
> +       select REGMAP_MMIO
>         help
>           This selects the Secure Digital Host Controller Interface (SDHCI)
>           support present in TI's AM654 SOCs. The controller supports
> --
> 2.38.0.135.g90850a2211-goog
>