[PATCH] ath9k: remove variable sent

Colin Ian King posted 1 patch 3 years, 5 months ago
drivers/net/wireless/ath/ath9k/xmit.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] ath9k: remove variable sent
Posted by Colin Ian King 3 years, 5 months ago
Variable sent is just being incremented and it's never used
anywhere else. The variable and the increment are redundant so
remove it.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/net/wireless/ath/ath9k/xmit.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index ba271a10d4ab..39abb59d8771 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -1678,7 +1678,6 @@ void ath9k_release_buffered_frames(struct ieee80211_hw *hw,
 	struct ieee80211_tx_info *info;
 	struct list_head bf_q;
 	struct ath_buf *bf_tail = NULL, *bf = NULL;
-	int sent = 0;
 	int i, ret;
 
 	INIT_LIST_HEAD(&bf_q);
@@ -1707,7 +1706,6 @@ void ath9k_release_buffered_frames(struct ieee80211_hw *hw,
 
 			bf_tail = bf;
 			nframes--;
-			sent++;
 			TX_STAT_INC(sc, txq->axq_qnum, a_queued_hw);
 
 			if (an->sta && skb_queue_empty(&tid->retry_q))
-- 
2.37.3
Re: [PATCH] ath9k: remove variable sent
Posted by Kalle Valo 3 years, 5 months ago
Colin Ian King <colin.i.king@gmail.com> wrote:

> Variable sent is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

4f6620cd6bbd wifi: ath9k: remove variable sent

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20221024153954.2168503-1-colin.i.king@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] ath9k: remove variable sent
Posted by Toke Høiland-Jørgensen 3 years, 5 months ago
Colin Ian King <colin.i.king@gmail.com> writes:

> Variable sent is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>