[PATCH] scsi: nsp_cs: remove variable i

Colin Ian King posted 1 patch 3 years, 5 months ago
drivers/scsi/pcmcia/nsp_cs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH] scsi: nsp_cs: remove variable i
Posted by Colin Ian King 3 years, 5 months ago
Variable i is just being incremented and it's never used
anywhere else. The variable and the increment are redundant so
remove it.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/scsi/pcmcia/nsp_cs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c
index 48acab03a8a0..a5a1406a2bde 100644
--- a/drivers/scsi/pcmcia/nsp_cs.c
+++ b/drivers/scsi/pcmcia/nsp_cs.c
@@ -450,8 +450,6 @@ static int nsp_analyze_sdtr(struct scsi_cmnd *SCpnt)
 	sync_data	      *sync   = &(data->Sync[target]);
 	struct nsp_sync_table *sync_table;
 	unsigned int	       period, offset;
-	int		       i;
-
 
 	nsp_dbg(NSP_DEBUG_SYNC, "in");
 
@@ -466,7 +464,7 @@ static int nsp_analyze_sdtr(struct scsi_cmnd *SCpnt)
 		sync_table = nsp_sync_table_40M;
 	}
 
-	for ( i = 0; sync_table->max_period != 0; i++, sync_table++) {
+	for (; sync_table->max_period != 0; sync_table++) {
 		if ( period >= sync_table->min_period &&
 		     period <= sync_table->max_period	 ) {
 			break;
-- 
2.37.3
Re: [PATCH] scsi: nsp_cs: remove variable i
Posted by Martin K. Petersen 3 years, 5 months ago
On Mon, 24 Oct 2022 15:11:01 +0100, Colin Ian King wrote:

> Variable i is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
> 
> 

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: nsp_cs: remove variable i
      https://git.kernel.org/mkp/scsi/c/25ad6f63e77e

-- 
Martin K. Petersen	Oracle Linux Engineering
Re: [PATCH] scsi: nsp_cs: remove variable i
Posted by Martin K. Petersen 3 years, 5 months ago
Colin,

> Variable i is just being incremented and it's never used anywhere
> else. The variable and the increment are redundant so remove it.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering